fix: refactor findingLastBucket into a func #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elbehery
force-pushed
the
refactor_finding_last_bucket_in_subBuckets
branch
from
dffaef3
to
d94a45b
Compare
|
Let's talk about the details on next Monday's meeting. |
ahrtr
reviewed
Nov 22, 2023
|
Sorry for the late response. Please also rebase this PR. |
|
sure, i just started to take my breath, still sick :'( |
Signed-off-by: Mustafa Elbehery <melbeher@redhat.com>
Elbehery
force-pushed
the
refactor_finding_last_bucket_in_subBuckets
branch
from
d94a45b
to
b5aaaeb
Compare
|
@ahrtr updated 👍🏽 |
ahrtr
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors finding a sub bucket logic into a helper func.
related to #602
cc @ahrtr