Remove the usage of atomic package #582
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refer to #213 Signed-off-by: Benjamin Wang <wachao@vmware.com>
tjungblu
reviewed
Oct 23, 2023
| // Note that `Cursor()` may be called by multiple readonly | ||
| // transactions concurrently, so we need to hold the lock | ||
| // `statlock` when updating the stats. | ||
| b.tx.db.statlock.Lock() |
There was a problem hiding this comment.
I understand that's very nitpicky, but do you know what the perf difference here would be? The cursor is pretty widely used and just taking a lock to increment an int seems a bit much.
tjungblu
reviewed
Oct 23, 2023
| tx.stats.IncPageCount(int64(count)) | ||
| tx.stats.IncPageAlloc(int64(count * tx.db.pageSize)) | ||
| tx.stats.PageCount += count | ||
| tx.stats.PageAlloc += count * tx.db.pageSize |
There was a problem hiding this comment.
count * tx.db.pageSize
could this overflow? count and page size are int32. edit: this certainly existed before, but maybe we should just declare count int64 directly.
|
Won't continue to work on this PR. Let's follow #584 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #577
To resolve the 64bit unaligned issue on arm32.
FYI. https://pkg.go.dev/sync/atomic#pkg-note-BUG