Change error handling logic in db.close() #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrtr
reviewed
Feb 5, 2023
db.go
Outdated
| @@ -649,9 +650,10 @@ func (db *DB) close() error { | |||
| // Clear ops. | |||
| db.ops.writeAt = nil | |||
|
|
|||
| var errs []string | |||
There was a problem hiding this comment.
Suggested change
| var errs []string | |
| var errs []error |
I suggest to only return the first error if present. It is consistent with the existing behavior. We will add log in separate PR to record all errors.
There was a problem hiding this comment.
Please resolve this comment: change the type to []error. It doesn't make sense to convert the errors to strings, and finally convert them back to errors.
|
Please signoff the commit: |
CaojiamingAlan
force-pushed
the
release-lock-on-unmap-error
branch
2 times, most recently
from
fa761d2 to
dddc5fd
Compare
ahrtr
requested changes
Feb 10, 2023
…or in the middle Signed-off-by: caojiamingalan <alan.c.19971111@gmail.com>
CaojiamingAlan
force-pushed
the
release-lock-on-unmap-error
branch
from
dddc5fd to
ef81032
Compare
ptabor
approved these changes
Feb 10, 2023
ahrtr
approved these changes
Feb 10, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#382 (comment)
Complete all cleanup operations in db.close() even if there is an error in the middle. Otherwise fd remains open and flock is not released.
Add a test mocking the munmap syscall fails. This test fails before this commit.