Revert the signature of tx.Check and add tx.CheckWithStringer
#395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptabor
reviewed
Jan 29, 2023
tx_check.go
Outdated
|
|
||
| // CheckWithStringer allows users to provide a customized `KVStringer` implementation, | ||
| // so that bolt can generate human-readable diagnostic messages. | ||
| func (tx *Tx) CheckWithStringer(kvStringer KVStringer) <-chan error { |
There was a problem hiding this comment.
Thank you. It's +- what I wanted to do:
How about more generic:
type CheckOptions struct{
KeyValueStringer KVStringer
}
CheckWithOptions(options CheckOptions) {...}
This will enable API compatibility going forward without the need to introduce additional methods.
There was a problem hiding this comment.
I agree it's more flexible. The only minor concern is that it might be a little over engineering for now.
Updated & thx.
There was a problem hiding this comment.
I am curious why we don't update the existing method (*Tx) Check() ? Why do we need to add a new one CheckWithOptions?
func (tx *Tx) Check(options ...CheckOption) <-chan error
Signed-off-by: Benjamin Wang <wachao@vmware.com>
ptabor
approved these changes
Jan 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #225 (comment)
Signed-off-by: Benjamin Wang wachao@vmware.com