Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate page being fetched at possition 'p' self identifies as page 'p' #358

Merged
merged 3 commits into from
Dec 23, 2022
Merged

Validate page being fetched at possition 'p' self identifies as page 'p' #358

merged 3 commits into from
Dec 23, 2022

Commits on Dec 23, 2022

  1. Validate page being fetched at possition 'p' self identifies as page … 

    …'p'.

It's the easiest verification whether the page is actually written, or its 'random' garbage in the block.

Signed-off-by: Piotr Tabor <ptab@google.com>
    @ptabor
    ptabor committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    d1aa803 View commit details
    Browse the repository at this point in the history

  2. Detect pages that have multiple flags set. 

    Signed-off-by: Piotr Tabor <ptab@google.com>
    @ptabor
    ptabor committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    3cbd9c9 View commit details
    Browse the repository at this point in the history

  3. Defensive: Expect page that node writes onto to be zeroed. 

    I've seen data corruption that seen like a random bit-flip
or application on already allocated page.

Signed-off-by: Piotr Tabor <ptab@google.com>
    @ptabor
    ptabor committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    86ce028 View commit details
    Browse the repository at this point in the history