Detect pages that have multiple flags set.

Signed-off-by: Piotr Tabor <ptab@google.com>
etcd-io · Dec 23, 2022 · 3cbd9c9 · 3cbd9c9
1 parent d1aa803
commit 3cbd9c9
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/node.go b/node.go
@@ -191,9 +191,9 @@ func (n *node) read(p *page) {
 func (n *node) write(p *page) {
 	// Initialize page.
 	if n.isLeaf {
-		p.flags |= leafPageFlag
+		p.flags = leafPageFlag
 	} else {
-		p.flags |= branchPageFlag
+		p.flags = branchPageFlag
 	}
 
 	if len(n.inodes) >= 0xFFFF {

diff --git a/page.go b/page.go
@@ -2,7 +2,6 @@ package bbolt
 
 import (
 	"fmt"
-	"log"
 	"os"
 	"sort"
 	"unsafe"
@@ -55,9 +54,13 @@ func (p *page) meta() *meta {
 }
 
 func (p *page) fastCheck(id pgid) {
-	if p.id != id {
-		log.Panicf("Page expected to be: %v, but self identifies as %v", id, p.id)
-	}
+	_assert(p.id == id, "Page expected to be: %v, but self identifies as %v", id, p.id)
+	// Only one flag of page-type can be set.
+	_assert(p.flags == branchPageFlag ||
+		p.flags == leafPageFlag ||
+		p.flags == metaPageFlag ||
+		p.flags == freelistPageFlag,
+		"page %v: has unexpected type/flags: %x", p.id, p.flags)
 }
 
 // leafPageElement retrieves the leaf node by index