Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Poetry, upgrade, lint and cleanup #99

Merged
merged 15 commits into from
Aug 26, 2022
Merged

Conversation

abulte
Copy link
Contributor

@abulte abulte commented Aug 23, 2022

My new passion is switching projects to Poetry, so this is done.

While struggling with it, a few bonuses:

  • upgrade pandas and pandas-profiling, since python 3.9 is now a requirement (dependencies were impossible to compute on python 3.7) — we'll have to switch the production env
  • fix tests locally
  • fix the CI that was apparently not running (wrong circle deploy key)
  • upgrade testing tooling
  • add a linting step (flake8) to CI because code quality was starting to get creepy 🧟 — I fixed the linting errors from kafka-integration 🎁

abulte added 10 commits August 23, 2022 14:58

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
- Explicitely upgrade to python >= 3.9
- Upgrade pandas and pandas-profiling
- Overhaul CI file
- Remove useless files
- Update License attribution
- Remove obsolete ansible roles
@abulte abulte changed the title Poetry flake8 Switch to Poetry, upgrade, lint and cleanup Aug 23, 2022
@abulte abulte requested a review from maudetes August 23, 2022 16:22
Copy link

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you for the well-needing clean.

I'm getting warnings now on csvapi serve. I didn't have these on kafka-integration branch, but it may be related to version pinned.

<frozen importlib._bootstrap>:219: RuntimeWarning: numpy.ufunc size changed, may indicate binary incompatibility. Expected 216 from C header, got 232 from PyObject

@abulte abulte merged commit da06697 into kafka-integration Aug 26, 2022
@abulte abulte deleted the poetry-flake8 branch August 26, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants