Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 404 support #69

Merged
merged 3 commits into from
Nov 17, 2020
Merged

Add 404 support #69

merged 3 commits into from
Nov 17, 2020

Conversation

quaxsze
Copy link
Contributor

@quaxsze quaxsze commented Nov 17, 2020

fix #68

@quaxsze
Copy link
Contributor Author

quaxsze commented Nov 17, 2020

Is checking for 404 enough or should we check anything different from 2xx status code?

@quaxsze quaxsze requested a review from abulte November 17, 2020 10:37
abulte
abulte reviewed Nov 17, 2020
View reviewed changes
abulte
abulte reviewed Nov 17, 2020
View reviewed changes
Copy link
Contributor

@abulte abulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple enough 👌 add a test?

@quaxsze quaxsze requested a review from abulte November 17, 2020 13:33
abulte
abulte approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@abulte abulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! You can release and deploy 💪

@quaxsze quaxsze merged commit dc560f1 into master Nov 17, 2020
@quaxsze quaxsze deleted the fix404 branch November 17, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abulte abulte abulte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong file type detection when requesting 404
2 participants
@quaxsze @abulte