fix(es_extended/client/functions.lua) RegisterInput and HashString bug #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the last update, **RegisterInput** tries to execute the command on key release due some checks removal in esx-framework#1303 . The check was restored and tested. **HashString** breaks when the joaat returns a hash bigger than 2^31. It was fix using a [shift mask](https://stackoverflow.com/a/20294714).
Gellipapa
requested changes
Oct 13, 2024
| end | ||
| RegisterKeyMapping("+" .. command_name, label or '', input_group or 'keyboard', key or '') | ||
| RegisterKeyMapping(command_name, label or '', input_group or 'keyboard', key or '') |
There was a problem hiding this comment.
Why removed '+' if you used 143 row?
There was a problem hiding this comment.
Made some testing, and apparently the plus sign is not required for RegisterKeyMapping. Tested in both cases where on_release is present and not.
Identical case for HashString inside of RegisterInput.
The only case where FiveM tries to trigger on_release is when the command name in RegisterCommand starts with a plus sign (+).
When on_release is not present, the command name in RegisterCommand doesn't use the symbol to prevent the following bug
There was a problem hiding this comment.
Thanks for test, and research, i merged.
Gellipapa
approved these changes
Oct 13, 2024
feelfreetofee
added a commit
to feelfreetofee/esx_core
that referenced
this pull request
Oct 15, 2024
|
Thank you very much, I had this problem too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the last update, RegisterInput tries to execute the command on key release due some checks removal in #1303. The check was restored and tested.
HashString breaks when the joaat returns a hash bigger than 2^31. It was fix using a shift mask.