source-zendesk-support: update ticket_skips schema #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zendesk seems to add & remove a default tag occassionally, causing our capture snapshot test to be flaky. I added a custom tag to our Zendesk account to ensure a tag is always present, and I redacted the tag fields in the capture snapshot so the test is more reliable.
Alex-Bair
added
the
change:unplanned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We have encountered schema violations for
ticket_skipswhere a custom field's value is an array of strings. Theticket_skips.jsonschema has been updated to allow this.I missed updating
posts.schema.yamlandticket_metrics.schema.yamlin previous PRs, so I've updated them now. Those previous PRs are:The capture snapshot test has also been flaky because Zendesk Support seems to delete & re-add the default tag I assumed would always be present. I added an organization tag in our Zendesk Support testing account to ensure a tag will always be present, and I redacted the tag fields in the capture snapshot so the test is more reliable.
Discover snapshot changes are expected due to making the
ticket_skipsschema more permissive. Capture snapshot changes are expected due to adding an organization tag in our Zendesk Support testing account & redacting tag fields in the snapshot.Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
Tested on a local stack. Confirmed the connector no longer crashes when
ticket_skipsencounters a document with a custom field value that's an array of strings.This change is