Fix shiki deprecation warning #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting slidev with the latest shiki version would produce the following warning: [slidev] `loadTheme` in `setup/shiki.ts` is deprecated. Pass directly the theme name it's supported by Shiki. For custom themes, load it manually via `JSON.parse(fs.readFileSync(path, 'utf-8'))` and pass the raw JSON object instead. This commit fixes the warning and also removes a redundant slash in develompment configuration.
|
Thanks @fgrandel for the fix! |
|
Version 0.0.16 just got released and includes your fix. 💪 |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting slidev with the latest shiki version would produce the following warning:
[slidev]
loadThemeinsetup/shiki.tsis deprecated. Pass directly the theme name it's supported by Shiki. For custom themes, load it manually viaJSON.parse(fs.readFileSync(path, 'utf-8'))and pass the raw JSON object instead.This commit fixes the warning and also removes a redundant slash in develompment configuration.