workaround: temporarily allow unused_imports warnings with tests #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenkoooo
approved these changes
Apr 11, 2024
fursich
commented
Apr 11, 2024
|
|
||
| // FIXME: workaround for false positive detection of unused_imports, which might be related to: | ||
| // https://github.com/rust-lang/rust/issues/121708 | ||
| #[allow(unused_imports)] |
There was a problem hiding this comment.
Ended up add this tentative workaround as the warning keeps coming up even after I specified all the import targets. (it disappears only if I remove struct_loader.ts file completely)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #10 failed because of lint errors that recently appeared. (thank you @mtshr for pointing this out!)
From what I understand it is false positive detection (possibly related to rust-lang/rust#121708 ??) with latest rustc, but I might be missing something.
@kenkoooo san, please let me know if you have any insights on this 🙏