Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ignore-missing behavior #29

Merged
merged 1 commit into from
Jun 7, 2017
Merged

Support ignore-missing behavior #29

merged 1 commit into from
Jun 7, 2017

Conversation

estesp
Copy link
Owner

@estesp estesp commented Jun 7, 2017

Enable an --ignore-missing parameter to the push subcommands that will
ignore any missing entries in YAML or provided os/arch list on the
command line. This allows a consistent YAML or command line to be used
and only do a "best effort" push of a manifest list depending on how
many of the source images are available at the time. If none are
available the push fails, understandably.

Signed-off-by: Phil Estes estesp@gmail.com

Fixes: #22
Closes: #13

Enable an `--ignore-missing` parameter to the push subcommands that will
ignore any missing entries in YAML or provided os/arch list on the
command line. This allows a consistent YAML or command line to be used
and only do a "best effort" push of a manifest list depending on how
many of the source images are available at the time. If none are
available the push fails, understandably.

Signed-off-by: Phil Estes <estesp@gmail.com>
@tianon
Copy link
Contributor

tianon commented Jun 7, 2017

😍

@estesp
Copy link
Owner Author

estesp commented Jun 7, 2017

@tianon I would love to release a 0.5.0 with this and the other Windows changes from yesterday as both are somewhat significant. Do you want to test anything here before I release?

I've tested that the basic skip function works fine:

WARN[0001] Couldn't find or access image reference "ppc64lel/debian:jessie". Skipping image. 
WARN[0002] Couldn't find or access image reference "aarch64/debian:1jessie". Skipping image. 
FATA[0002] all entries were skipped due to missing source image references; no manifest list to push.

@tianon
Copy link
Contributor

tianon commented Jun 7, 2017 via email

@estesp estesp merged commit 8f4bb13 into master Jun 7, 2017
@estesp estesp deleted the ignore-missing branch June 7, 2017 16:43
@estesp estesp restored the ignore-missing branch September 25, 2018 15:39
@estesp estesp deleted the ignore-missing branch March 21, 2019 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants