Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added scalajs support #5

Merged
merged 3 commits into from
Feb 22, 2018
Merged

added scalajs support #5

merged 3 commits into from
Feb 22, 2018

Conversation

kailuowang
Copy link
Contributor

No description provided.

@kailuowang kailuowang mentioned this pull request Feb 12, 2018
Closed
@carymrobbins
Copy link
Member

@kailuowang I'm currently working on @newtype macro support, and that should be available soon. I assume this is something you'd want for ScalaJS as well? If so, what additional changes might need to be made and/or considered for this to work?

@kailuowang
Copy link
Contributor Author

I am not 100% sure but I believe there is no additional change needed, it should just work. You just need to move the new macro related sbt settings to inside the settings(....) like all the other settings. I can definitely help if you have trouble get it working with your macro branch.

@carymrobbins carymrobbins merged commit 606dc84 into estatico:master Feb 22, 2018
@carymrobbins
Copy link
Member

I'm going to wrap up the macro stuff and then make a release by the end of the week. Thanks @kailuowang!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kailuowang @carymrobbins