newsubtype #14
Merged
newsubtype #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carymrobbins
force-pushed
the
newsubtype
branch
from
2758733
to
66b7372
Compare
carymrobbins
force-pushed
the
newsubtype
branch
from
66b7372
to
58fccd1
Compare
joroKr21
reviewed
Mar 19, 2018
| case (Nil, false) => q"type Type <: Base with Tag" | ||
| case (tparams, false) => q"type Type[..$tparams] <: Base with Tag[..$tparamsNames]" | ||
| case (Nil, true) => q"type Type = Base with Tag" | ||
| case (tparams, true) => q"type Type[..$tparams] = Base[..$tparamsNames] with Tag[..$tparamsNames]" |
There was a problem hiding this comment.
Wouldn't this lead to problems with type inference again? What do we gain from using = instead of <:?
There was a problem hiding this comment.
I think this was the result of me thinking that the abstract type was causing boxing, but later I realized boxing was happening for a different reason (which you commented on as well -
scala/bug#10770).
Just added a commit to fix this and all looks good, nice catch!
Thanks to @joroKr21 for pointing this out #14 (comment)
carymrobbins
force-pushed
the
newsubtype
branch
from
39a1fd5
to
2889577
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.