Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate <expr-atom> in the language spec #105

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Eliminate <expr-atom> in the language spec #105

merged 1 commit into from
Jul 17, 2023

Conversation

mohammadfawaz
Copy link
Contributor

It is somewhat unnecessary

Closes #99

@mohammadfawaz mohammadfawaz self-assigned this Jul 14, 2023
@mohammadfawaz mohammadfawaz added the Specs 📖 Specification documents label Jul 14, 2023
otrho
otrho approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@otrho otrho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, BNF can be left recursive, since it resembles the old LR grammars.

@mohammadfawaz mohammadfawaz merged commit bf29799 into master Jul 17, 2023
@mohammadfawaz mohammadfawaz deleted the mohammadfawaz/99 branch July 17, 2023 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otrho otrho otrho approved these changes

@sezna sezna Awaiting requested review from sezna

@lethalgem lethalgem Awaiting requested review from lethalgem

Assignees

@mohammadfawaz mohammadfawaz

Labels
Specs 📖 Specification documents
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

What's an expr-atom in the spec? Can it just be expr?
2 participants
@mohammadfawaz @otrho