Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip example binaries #295

Closed
flxo opened this issue Feb 16, 2021 · 1 comment · Fixed by #565
Closed

Strip example binaries #295

flxo opened this issue Feb 16, 2021 · 1 comment · Fixed by #565
Assignees
@flxo
Labels
easy Good for newcomers enhancement New feature or request

Comments

@flxo
Copy link
Member

flxo commented Feb 16, 2021

When building the examples a plain cargo build --release ... build is done.

Add a strip step with einer RUSTC_FLAGS or cargo-strip.
@flxo flxo added the enhancement New feature or request label Feb 16, 2021
@flxo flxo added the easy Good for newcomers label May 19, 2021
@inorick
Copy link
Collaborator

inorick commented Jun 23, 2021 •
edited
Loading

Rust nightly now supports stripping of binaries (rust-lang/rust#72110 (comment)). Once it is stable, we can use it.

flxo added a commit to flxo/northstar that referenced this issue Apr 12, 2022
@flxo
Strip release binaries
80af0a5 
With rustc 1.59 and cargo 1.60 the `strip` option is fully supported.
On onlder rust and cargo versions a warning is generated.

Fixes esrlabs#295
@flxo flxo mentioned this issue Apr 12, 2022
Merged
flxo added a commit to flxo/northstar that referenced this issue Apr 12, 2022
@flxo
Strip release binaries
fda2e32 
With rustc 1.59 and cargo 1.60 the `strip` option is fully supported.
Raise the MSRV to 1.59.

Fixes esrlabs#295
@flxo flxo assigned flxo and unassigned marcmo Apr 20, 2022
flxo added a commit to flxo/northstar that referenced this issue Apr 27, 2022
@flxo
Strip release binaries
3dbad4c 
With rustc 1.59 and cargo 1.60 the `strip` option is fully supported.
Raise the MSRV to 1.59.

Fixes esrlabs#295
@flxo flxo closed this as completed in #565 May 2, 2022
flxo added a commit that referenced this issue May 2, 2022
@flxo
Strip release binaries
d1690e0 
With rustc 1.59 and cargo 1.60 the `strip` option is fully supported.
Raise the MSRV to 1.59.

Fixes #295
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flxo flxo

Labels
easy Good for newcomers enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Strip release binaries flxo/northstar
3 participants
@marcmo @flxo @inorick