Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminalclock: Add option for ISO 8601 date format #3739

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

JimMadge
Copy link

@JimMadge JimMadge commented Feb 8, 2025

This PR adds a boolean setting for the terminalclock app. When true the date line will display render in the ISO 8601 format (like, 2025-02-08) rather than using locale.

The setting is false by default to preserve backwards compatibility with existing settings files.

I've tested from my fork using my Bangle.js 2.

@bobrippling
Copy link
Collaborator

Thanks for the PR - all of the whitespace changes are in with code changes, can you split them into separate commits so it's easy to view functional changes to the code? (and if we need to come back later, we won't have conflicts due to whitespace if we need to cherry-pick or otherwise move the commit around)

@JimMadge
Copy link
Author

Thanks for the PR - all of the whitespace changes are in with code changes, can you split them into separate commits so it's easy to view functional changes to the code? (and if we need to come back later, we won't have conflicts due to whitespace if we need to cherry-pick or otherwise move the commit around)

Sure, no problem. I'll get on to that soon. (I read the note in the contributing guide about whitespace changes too late 😅)

@JimMadge JimMadge requested a review from bobrippling February 14, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants