messagegui: swipe up/down on msg goes to newer/older msg #3215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thyttan
force-pushed
the
messagegui
branch
2 times, most recently
from
40743f0 to
ec5b495
Compare
thyttan
changed the title
|
I'm happy with this idea - but personally I'd prefer if the |
thyttan
force-pushed
the
messagegui
branch
2 times, most recently
from
66e9ed1 to
66d422e
Compare
|
@gfwilliams I did the change you suggested. Also refactored the function getting the index to a variable, see 66d422e. Tried it on my watch and it works still. |
|
Thanks! That looks good to me... |
|
I'll run this for a day or two and mark as ready for review if everything seems good. I added the update to my app loader: https://thyttan.github.io/BangleApps/?q=messagegui |
|
I believe this is fine. |
messagegui: small refactor of swipeHandler `if (ud!=0)` -> `if (ud>0) ... if (ud<0)`
|
Yeah looks good to me too - I don't use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swipe up/down on a shown message to show newer/older message.
I would personally rather map up/down to older/newer. But I think up/down mapped with newer/older makes more sense with how 'tick' and 'cross' swipes are done and how the messages are presented in the scroller list.
Thoughts? @gfwilliams @bobrippling
The change can be tried by installing from my app loader: https://thyttan.github.io/BangleApps/?q=messagegui