agenda: Fixed "Today" and "Yesterday" wrongly displayed for allDay events on some time zones #2857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents on some time zones
|
Nice - thanks! That's a pain though - I wonder if that hits us in other places too where we use ISOstring |
|
I would say so, if it's trimmed to check the date, it can definitely give +1 or -1 days depending on the time and timezone.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way we were comparing the date for Today and Yesterday was to compute the ISOstring, extract the date and compare that with today's. Such date is however in UTC and allDay events start at midnight, which makes them belong to the previous day on half of the time zones (the same problem could appear on other events earlier than the time zone's offset).
With this PR we compare day and month, which is safer as it should take into consideration also time zones.
Fixes: #2856