Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable kaniko cache #96

Merged
merged 12 commits into from
Oct 11, 2019
Merged

re-enable kaniko cache #96

merged 12 commits into from
Oct 11, 2019

Conversation

mkuron
Copy link
Member

@mkuron mkuron commented Jun 4, 2019

reverts #93

It‘s possible that the caching issue was resolved by splitting the build and deploy stages. To find out whether that is the case, I‘ve created this pull request.

@mkuron
Copy link
Member Author

mkuron commented Jun 6, 2019

Rerunning the pipeline a few times produced a corrupted centos:7 image (https://gitlab.icp.uni-stuttgart.de/espressomd/docker/-/jobs/120796), so we'll keep this issue WIP until an appropriate kaniko update has been released or I manage to track down myself why caching is broken.

@jngrad jngrad mentioned this pull request Jun 19, 2019
@KaiSzuttor
Copy link
Member

probably related GoogleContainerTools/kaniko#575

@KaiSzuttor
Copy link
Member

bwcloud seems to have trouble with the exotic arches

@jngrad
Copy link
Member

jngrad commented Jun 26, 2019

This happens quite frequently with QEMU images. Just retry the job until it works, the worst case I had was 3 retries. This is already documented in #97.

@mkuron
Copy link
Member Author

mkuron commented Sep 26, 2019

I have set up a nightly job for https://gitlab.icp.uni-stuttgart.de/espressomd/docker/commit/60d7eb33b4c74f90ea74bb5b0f966a8140b96a65/pipelines and we shall see whether the cache now works reliably. If it does for a few weeks, we can merge this pull request.

@KaiSzuttor
Copy link
Member

the related PR GoogleContainerTools/kaniko#715 is still open... Why should the situation have changed?

@mkuron
Copy link
Member Author

mkuron commented Sep 26, 2019

They have closed a bunch of cache-related issues in recent weeks and I don't think that that pull request is really related. I already tried a few builds yesterday and didn't find cache errors. We shall hope and see.

@KaiSzuttor
Copy link
Member

probably GoogleContainerTools/kaniko#639 but it's quite old? Let's see

@mkuron mkuron changed the title WIP: re-enable kaniko cache re-enable kaniko cache Oct 7, 2019
@mkuron
Copy link
Member Author

mkuron commented Oct 11, 2019

Caching seems to be reliable now. Two weeks of successful rebuilds: https://gitlab.icp.uni-stuttgart.de/espressomd/docker/commit/60d7eb33b4c74f90ea74bb5b0f966a8140b96a65/pipelines. Please go ahead and merge this pull request. It speeds up the average pipeline by a factor of three.

Copy link
Member

@jngrad jngrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the environment says thanks

@jngrad jngrad merged commit 7e2a2cf into espressomd:master Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants