feat: token details page #1501
Open
feat: token details page #1501
+1,210
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ookami-kb
reviewed
Jan 6, 2025
|
#1664 |
ookami-kb
requested changes
Jan 12, 2025
| @@ -0,0 +1,134 @@ | |||
| // ignore_for_file: avoid-single-child-column-or-row | |||
There was a problem hiding this comment.
Why is it needed? Can you do it without row?
| const SizedBox(height: 16), | ||
| ...sortedDates.map((date) { | ||
| final transactions = data[date]; | ||
| late final IList<TxCommon> sortedTxs; |
There was a problem hiding this comment.
This looks error-prone. What if transactions == null? It will never be initialized.
Also, the whole mapping in widget looks too complex, let's extract it to logic layer – no bloc is needed but something lightweight like ChangeNotifier would make sense for preparing the data.
| mint: Ed25519HDPublicKey.fromBase58(Token.usdc.address), | ||
| ); | ||
| @PostConstruct() | ||
| void init() { |
There was a problem hiding this comment.
Why not just mark call as @PostConstruct?
|
Solana beta workflow has 1 test failing, version 2.1.8 was just release without changelog currently. https://github.com/anza-xyz/agave/releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Display token details upon click
Related issues
Fixes #1496
Videos
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-07-12.at.17.36.47.mp4
Android_1080x2400_420p.mp4
Checklist