-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VSC-1496] add idf monitorPort conf setting and cmds #1429
base: master
Are you sure you want to change the base?
Conversation
Download the artifacts for this pull request: |
4cf8cd6
to
3eb5072
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed working on Windows, Mac and Ubuntu Linux.
Removing the configuration form user settings remove the button on VSCode status bar.
Description
Add
idf.monitorPort
andESP-IDF: Select Monitor Port to Use (COM, tty, usbserial)
for an optional and additional port setting to be used in Monitor tasks.This setting overrides
idf.port
for monitor tasks when defined.This setting is shown in the status bar next to flash port when defined and nothing is shown when undefined.
Fixes #1321
Type of change
Steps to test this pull request
Provide a list of steps to test changes in this PR and required output
ESP-IDF: Select Monitor Port to Use (COM, tty, usbserial)
and select a serial port for monitor. The selected serial port should be saved in workspace folder settings and shown in the status bar and when click the previous command is executed.ESP-IDF: Monitor your device
. The serial port used should beidf.monitorPort
.idf.monitorPort
from workspace folder setting. ExecuteESP-IDF: Monitor your device
. The serial port used should beidf.port
. The status bar item for monitor port is not shown anymore.Expected behaviour:
Expected output:
How has this been tested?
Manual testing using steps above.
Test Configuration:
Checklist