-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VSC-1573] ensure build directories exist and resolve relative paths #1417
Open
radurentea
wants to merge
4
commits into
master
Choose a base branch
from
bugfix/multi-config-relative-build-path
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
599caa2
ensure build directories exist and resolve relative paths
radurentea c4b81a9
wip: Fix for absolute path; Handle invalid path
radurentea 8a06a60
Fix relative paths; Fix build errors
radurentea 7c44b0c
make resolveConfigPaths synchronous
radurentea File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,6 +16,7 @@ | |
* limitations under the License. | ||
*/ | ||
|
||
import * as path from "path"; | ||
import { | ||
env, | ||
StatusBarAlignment, | ||
|
@@ -31,6 +32,7 @@ import { ESP } from "../config"; | |
import { CommandItem } from "../cmdTreeView/cmdTreeDataProvider"; | ||
import { CommandKeys, createCommandDictionary } from "../cmdTreeView/cmdStore"; | ||
import { getIdfTargetFromSdkconfig } from "../workspaceConfig"; | ||
import { pathExists } from "fs-extra"; | ||
|
||
export const statusBarItems: { [key: string]: StatusBarItem } = {}; | ||
|
||
|
@@ -61,6 +63,12 @@ export async function createCmdsStatusBarItems(workspaceFolder: Uri) { | |
let projectConf = ESP.ProjectConfiguration.store.get<string>( | ||
ESP.ProjectConfiguration.SELECTED_CONFIG | ||
); | ||
let projectConfPath = path.join( | ||
workspaceFolder.fsPath, | ||
ESP.ProjectConfiguration.PROJECT_CONFIGURATION_FILENAME | ||
); | ||
let projectConfExists = await pathExists(projectConfPath); | ||
|
||
let currentIdfVersion = await getCurrentIdfSetup(workspaceFolder, false); | ||
|
||
statusBarItems["workspace"] = createStatusBarItem( | ||
|
@@ -101,16 +109,31 @@ export async function createCmdsStatusBarItems(workspaceFolder: Uri) { | |
); | ||
} | ||
|
||
if (projectConf) { | ||
statusBarItems["projectConf"] = createStatusBarItem( | ||
`$(${ | ||
commandDictionary[CommandKeys.SelectProjectConfiguration].iconId | ||
}) ${projectConf}`, | ||
commandDictionary[CommandKeys.SelectProjectConfiguration].tooltip, | ||
CommandKeys.SelectProjectConfiguration, | ||
99, | ||
commandDictionary[CommandKeys.SelectProjectConfiguration].checkboxState | ||
); | ||
if (projectConfExists) { | ||
if (!projectConf) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
let statusBarItemName = "Invalid Path"; | ||
let statusBarItemTooltip = | ||
"Invalid configuration path. Click to modify project configuration"; | ||
statusBarItems["projectConf"] = createStatusBarItem( | ||
`$(${ | ||
commandDictionary[CommandKeys.SelectProjectConfiguration].iconId | ||
}) ${statusBarItemName}`, | ||
statusBarItemTooltip, | ||
"espIdf.projectConfigurationEditor", | ||
99, | ||
commandDictionary[CommandKeys.SelectProjectConfiguration].checkboxState | ||
); | ||
} else { | ||
statusBarItems["projectConf"] = createStatusBarItem( | ||
`$(${ | ||
commandDictionary[CommandKeys.SelectProjectConfiguration].iconId | ||
}) ${projectConf}`, | ||
commandDictionary[CommandKeys.SelectProjectConfiguration].tooltip, | ||
CommandKeys.SelectProjectConfiguration, | ||
99, | ||
commandDictionary[CommandKeys.SelectProjectConfiguration].checkboxState | ||
); | ||
} | ||
} | ||
|
||
statusBarItems["target"] = createStatusBarItem( | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Await is not needed if function is not asynchronous