[VSC-1573] ensure build directories exist and resolve relative paths #1417
Conversation
- Replace forEach with Promise.all for proper async handling - Automatically create build directories using ensureDir - Convert relative paths to absolute using workspace folder as base - Refactor build config access for better readability
|
Download the artifacts for this pull request: |
| commandDictionary[CommandKeys.SelectProjectConfiguration].checkboxState | ||
| ); | ||
| if (projectConfExists) { | ||
| if (!projectConf) { |
There was a problem hiding this comment.
projectConf doesn't mean is an error. Means the user has not selected a profile at the moment. Even if ESP.ProjectConfiguration.PROJECT_CONFIGURATION_FILENAME exists.
| compileArgs: buildConfig?.compileArgs, | ||
| ninjaArgs: buildConfig?.ninjaArgs, | ||
| buildDirectoryPath: buildDirPath, | ||
| sdkconfigDefaults: (await resolveConfigPaths( |
There was a problem hiding this comment.
Await is not needed if function is not asynchronous
|
I've tested this PR with this example config-test project but the build directory resolution is wrong. Generated build directory is Also if I set the path |
|
Project Configuration Editor related bug: When |
Description
Fixed an issue where relative paths in project configurations were not being handled correctly and build directories were not being created automatically. The extension now properly resolves relative paths to absolute using the workspace folder as the base and ensures build directories exist before build commands are executed.
Fixes #1408
Fixes #1430
Type of change
Steps to test this pull request
{ "prod1": { "build": { "compileArgs": [], "ninjaArgs": [], "buildDirectoryPath": "build.prod1", "sdkconfigDefaults": [ "sdkconfig.prod_common", "sdkconfig.prod1" ], "sdkconfigFilePath": "" }, "env": {}, "flashBaudRate": "", "monitorBaudRate": "", "openOCD": { "debugLevel": 0, "configs": [], "args": [] }, "tasks": { "preBuild": "", "preFlash": "", "postBuild": "", "postFlash": "" } }, "prod2": { "build": { "compileArgs": [], "ninjaArgs": [], "buildDirectoryPath": "build.prod2", "sdkconfigDefaults": [ "sdkconfig.prod_common", "sdkconfig.prod2" ], "sdkconfigFilePath": "" }, "env": {}, "flashBaudRate": "", "monitorBaudRate": "", "openOCD": { "debugLevel": 0, "configs": [], "args": [] }, "tasks": { "preBuild": "", "preFlash": "", "postBuild": "", "postFlash": "" } } }Expected behaviour:
How has this been tested?
As described above
Test Configuration:
Checklist