Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow fix + update edk2 submodule (QEMU-229) #111

Closed
wants to merge 0 commits into from

Conversation

Throows
Copy link

@Throows Throows commented Dec 26, 2024

Description

This PR fix the github CI workflow for mingw32, and fix the upload job (ActionCheckout@V4).

Related

Fixes #106

Testing

the CI workflow is successful on my fork on the esp_develop branch


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@github-actions github-actions bot changed the title Workflow fix + update edk2 submodule Workflow fix + update edk2 submodule (QEMU-229) Dec 26, 2024
@igrr
Copy link
Member

igrr commented Dec 27, 2024

@Throows thanks for the PR! It seems you have made it on top of some temporary branch in this repo, was that intentional?

@Throows
Copy link
Author

Throows commented Dec 27, 2024

Hi, absolutely.
Since it was an ongoing branch, I thought someone else might want to contribute something else.
My part is completed you can merge it if you want. 😄
Romain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants