Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESP32-C6-DevkitC-1 symbol and footprint #103

Merged
merged 4 commits into from
Jun 5, 2023

Conversation

nickoe
Copy link
Contributor

@nickoe nickoe commented May 29, 2023

Fixes #99

The symbol and footprint are derived from the ESP32-S2-DevkitC-1, as I thought it was most similar. Please review.

image

image

@pedrominatel pedrominatel self-requested a review May 30, 2023 07:38
@pedrominatel pedrominatel added new symbol New symbol request new footprint New footprint request labels May 30, 2023
@nickoe
Copy link
Contributor Author

nickoe commented May 31, 2023

@pedrominatel In kicad 7 we can add alternative pin definitions. Should I attempt to add some of those as well?

In this one I added /foo to some pins, but as a subjective judgement. Bootstrapping pins, UART0, and ADC. Is there any guideline for preference established for this repo? I don't see one in particular.

@pedrominatel
Copy link
Member

Hi @nickoe,

I think we can try to use this feature on this symbol and see if we change the others.
Can you explain more about the "guideline for preference"?

Thanks

Copy link
Member

@pedrominatel pedrominatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrominatel
Copy link
Member

Hi @nickoe, can you fix the conflict? Now we are moving to PCM approach and this new symbol and footprint will be included in the next release.

@nickoe
Copy link
Contributor Author

nickoe commented Jun 5, 2023

@pedrominatel Yeah, I will fix it. I will also add an update with the alternate pin definitions. I am considering to remove all the pin silkscreen labels. They are a lot in the way if one decides to mount stuff under the module. I also fixed a typo for GPIO22 on pin 27.

nickoe added 4 commits June 5, 2023 12:31
Based on the ESP32-S2-DevKitC-1
This is derived from the ESP32-S2-DevKitC-1 footprint to keep style and
addapted as best effort in relation to the dimensional drawings and a
simplified version of the dxf provided with the espressif documentation.

I am not so sure about the tilde suffixes used in the S2 footprint
design, I think they are meant to mean PWM capable outputs. Possibly and
Arduinoism. I added them on essentially all pins and this what the
espressif documentation stats as PWM capable pins,... but yet they have
it on the 5V pin.
- Use GPIOx/ notation on all alternate pins
- Keep strapping pin functions as defaults, plus for USB and UART0
- Fixed a typo for GPIO22 on pin 27
@nickoe
Copy link
Contributor Author

nickoe commented Jun 5, 2023

Mm, I did not intentionally close this pull request.

@nickoe nickoe reopened this Jun 5, 2023
@pedrominatel pedrominatel self-requested a review June 5, 2023 10:46
@pedrominatel
Copy link
Member

Thanks @nickoe, I'll take a look and merge as soon as possible.

Copy link
Member

@pedrominatel pedrominatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrominatel pedrominatel merged commit a93b03e into espressif:main Jun 5, 2023
@tomlevisse
Copy link

Is there a 3D model ?

@nickoe
Copy link
Contributor Author

nickoe commented Jun 6, 2023

I don't have one. I don't intend to fabricate one. Feel free to attempt that. I wonder if the other 3D models are contributor generared or of they are exports from espressiff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new footprint New footprint request new symbol New symbol request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ESP32-C6-DevkitC-1 library?
3 participants