feat(spi_nand_flash): expose lower-level API and make it usable without Dhara #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
RathiSonika
force-pushed
the
feat/spi_nand_expose_lower_level_api
branch
4 times, most recently
from
b66eda8 to
fe2657f
Compare
RathiSonika
force-pushed
the
feat/spi_nand_expose_lower_level_api
branch
3 times, most recently
from
8196058 to
eb3dfe2
Compare
|
Generally LGTM, but why do you place spi_nand_api.h into private includes? Isn't this PR about exposing the APIs? |
igrr
reviewed
Nov 21, 2024
There was a problem hiding this comment.
@RathiSonika LGTM overall, looks like a nice improvement. I left a few comments for discussion.
This is actually a private header for this component. The APIs defined here are used internally within the component and are not public APIs. I understand the name might be confusing, so I’ll rename it. |
RathiSonika
force-pushed
the
feat/spi_nand_expose_lower_level_api
branch
2 times, most recently
from
0601427 to
d83e3a6
Compare
RathiSonika
force-pushed
the
feat/spi_nand_expose_lower_level_api
branch
2 times, most recently
from
8a0ba94 to
c2fd329
Compare
|
@igrr PTAL. Thank you! |
igrr
approved these changes
Nov 29, 2024
RathiSonika
force-pushed
the
feat/spi_nand_expose_lower_level_api
branch
from
86bceb9 to
dedb5e8
Compare
RathiSonika
force-pushed
the
feat/spi_nand_expose_lower_level_api
branch
from
ab1e619 to
eb4e40c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spi_nand_flash
└── src
├── nand.c : Defines all public interfaces; includes definitions for spi_nand_flash.h
├── nand_gigadevice.c : Initializes chip-specific settings for GigaDevice
├── nand_micron.c : Initializes chip-specific settings for Micron
├── nand_winbond.c : Initializes chip-specific settings for Winbond
├── nand_alliance.c : Initializes chip-specific settings for Alliance
├── spi_nand_oper.c : Contains lower-level SPI communication APIs
├── nand_impl.c : Implements lower-level APIs such as nand_erase, nand_mark_bad, nand_prog, etc.
├── nand_impl_wrap.c : Implements wrapper functions for lower-level APIs implemented in nand_impl.c
└── dhara_glue.c : Initializes and defines Dhara-related APIs and registers function pointers in nand.c. Only
dhara_glue.c depends on the Dhara library, making it easy to replace with another library if
needed, allowing the code to function independently of Dhara.
Refactoring nand.c and the chip-specific settings is possible; however, this PR primarily focuses on exposing lower-level APIs and enabling easy replacement of the Dhara library in the future, if needed.
Checklist
Change description