update(spi_nand_flash): handle alignment and DMA requirements for work buffers #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
RathiSonika
force-pushed
the
update/nand_flash_work_buf_alignment
branch
2 times, most recently
from
d39fb08
to
48c3abe
Compare
igrr
reviewed
Oct 16, 2024
RathiSonika
force-pushed
the
update/nand_flash_work_buf_alignment
branch
from
48c3abe
to
548138d
Compare
RathiSonika
force-pushed
the
update/nand_flash_work_buf_alignment
branch
from
548138d
to
7630872
Compare
igrr
reviewed
Oct 17, 2024
igrr
reviewed
Oct 17, 2024
RathiSonika
force-pushed
the
update/nand_flash_work_buf_alignment
branch
from
7630872
to
512b347
Compare
igrr
approved these changes
Oct 21, 2024
RathiSonika
force-pushed
the
update/nand_flash_work_buf_alignment
branch
from
512b347
to
3a550d8
Compare
pacucha42
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently spi_nand_flash component passes pointers to TX and RX buffers to spi_master driver. However, these pointers sometimes are either not in DMA-capable memory or not aligned properly, and as a result spi_master driver allocates a temporary buffer for every transaction and copies the data to/from it. This also applies to cases when the transaction is just a couple of bytes long.
In this PR: