Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USB Host MSC v1.1.1 #232

Merged
merged 3 commits into from
Oct 2, 2023
Merged

USB Host MSC v1.1.1 #232

merged 3 commits into from
Oct 2, 2023

Conversation

tore-espressif
Copy link
Collaborator

Change description

  • Correctly handle empty string descriptors
  • Move data buffer to DMA capable memory, if non-capable memory is passed to the driver

PTAL @Dazza0 @roma-jam
cc @leeebo @lijunru-hub @Maldus512 @0727fqh @f1andrew

Closes espressif/esp-idf#12163
Closes #202
Closes espressif/esp-idf#12142

@github-actions
Copy link

github-actions bot commented Sep 9, 2023 •
edited
Loading

Unit Test Results

  11 files  ±0    11 suites  ±0   14m 49s ⏱️ -21s
  27 tests ±0    27 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
252 runs  ±0  252 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f17af56. ± Comparison against base commit a8482e0.

♻️ This comment has been updated with latest results.

@tore-espressif tore-espressif changed the title Fix/usb/msc string descriptors USB Host MSC v1.1.1 Sep 9, 2023
@tore-espressif tore-espressif force-pushed the fix/usb/msc-string-descriptors branch 3 times, most recently from 81f1fd3 to e01cfa8 Compare September 12, 2023 18:42
roma-jam
roma-jam approved these changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@roma-jam roma-jam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments.
Otherwise, LGTM. 👏

@tore-espressif tore-espressif self-assigned this Oct 1, 2023
@tore-espressif tore-espressif merged commit fef5867 into master Oct 2, 2023
64 checks passed
@tore-espressif tore-espressif deleted the fix/usb/msc-string-descriptors branch October 2, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roma-jam roma-jam roma-jam approved these changes

@leeebo leeebo leeebo left review comments

@Dazza0 Dazza0 Awaiting requested review from Dazza0

Assignees

@tore-espressif tore-espressif

Labels
Component: usb
Projects
None yet
Milestone
No milestone
3 participants
@tore-espressif @roma-jam @leeebo