refactor(led_strip): Remove the hack code (IEC-37) #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
|
@Kainarx Thanks for the cleanup. For some reason, we need to delay this PR until the SPI driver fix (espressif/esp-idf@8f5851d) got merged into esp-idf 's release/v5.1 branch. Edit: Now the fix got backport to the release/v5.1 branch: espressif/esp-idf@77b74ab |
suda-morris
approved these changes
Aug 8, 2023
Since the spi driver has fixed the idle level of MOSI. Remove the operation which controls the register.
suda-morris
force-pushed
the
refactor/led_strip_component__remove_the_hack_code
branch
from
70320d7
to
e78991f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the spi driver has fixed the idle level of MOSI. Remove the operation which controls the register.
Checklist
urlfield definedChange description
Please describe your change here