check components in PRs #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igrr
force-pushed
the
ci/component_upload_dry_run
branch
3 times, most recently
from
989d6f7
to
ad9dd06
Compare
|
Unfortunately looks like this doesn't work in general, because |
This was referenced Jul 28, 2023
|
Looks like this will be solved by espressif/idf-component-manager@488bf90. |
igrr
force-pushed
the
ci/component_upload_dry_run
branch
from
ad9dd06
to
c02776c
Compare
|
dry-run is not noticing the lack of the license file, will probably need a fix on idf-component-manager side. |
igrr
force-pushed
the
ci/component_upload_dry_run
branch
2 times, most recently
from
389adfd
to
41a78f6
Compare
|
Okay, looks like the dry-run is able to detect some of the issues: So i think this PR is ready. @tore-espressif please take a look again! |
tore-espressif
approved these changes
Oct 5, 2023
tore-espressif
force-pushed
the
ci/component_upload_dry_run
branch
from
41a78f6
to
e5df447
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify components in PRs by running the upload action with --dry-run argument (based on espressif/upload-components-ci-action#12)
Will hopefully prevent issues like #219 and #161.