-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coap: Update to latest libcoap code (4.3.2rc1) (IEC-32) #215
Conversation
30200d9
to
f201d9b
Compare
5ed1862
to
140ebdf
Compare
Thank you for taking care of this update! Just wanted to inform you that we have been experimenting with the SBOM related tool to assist in monitoring the application against known security vulnerabilities. At this moment, if we run the tool against coap examples then it reports following vulnerabilities from coap component:
As I see that corresponding fixes have been merged upstream and hence with this PR, we should have clean run for the coap examples against any known security issues. Just FYI. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have done some static code analysis. Here are the results:
Example Version | DRAM .data | DRAM .bss | Flash .text | Flash .rodata | Flash Total |
---|---|---|---|---|---|
Coap Client(PR) | 684 | 10358 | 47449 | 6602 | 54735 |
Coap Client(Master) | 256 | 10890 | 47769 | 14160 | 62185 |
Coap Server(PR) | 704 | 12022 | 56167 | 7674 | 64545 |
Coap Server(Master) | 276 | 12678 | 60447 | 16280 | 77003 |
These look good. A large part will be down the removal of code for the higher level logging. |
Code changes pushed. Updated examples to easily support CoAP over WebSockets if WebSockets is enabled. |
4175fcb
to
fe4d830
Compare
Minor comments, otherwise LGTM! |
Thanks for all your help in checking this through. |
Checklist
url
field definedChange description
Update libcoap to the latest version.
Code now builds if IPv4 or IPv6 is not available.