refactor(esp_tinyusb/cdc): Remove receive ring buffer #205
Conversation
There was a problem hiding this comment.
Hey @tore-espressif well done!
I have left some comments, which are not critical at all. Just a few suggestions.
Also, I have tried to launch pytest for the tusb_device part and it seems that it is too difficult for me.
As far as I understand I do not need to devices here to test the logic, or do I?
Based on this, maybe it is a good idea to put somewhere the description how to launch a test locally.
What do you think? Or we have such a description and there is only me who doesn't know about that?
Otherwise, LGTM.
There was a problem hiding this comment.
Thank you for the review @roma-jam @esp-saurabhbansal , I will update the code ASAP
tore-espressif
force-pushed
the
feature/esp_tinyusb/optimize_cdc
branch
from
b6a7395
to
e22ec82
Compare
|
@esp-saurabhbansal @roma-jam Thank you very much for your reviews. I fixed all the issues. Moreover, I update CMake so we don't require unnecessary components, PTAL! |
tore-espressif
force-pushed
the
feature/esp_tinyusb/optimize_cdc
branch
from
e22ec82
to
ce58750
Compare
- CDC-ACM: Remove intermediate RX ringbuffer - CDC-ACM: Increase default FIFO size to 512 bytes - CDC-ACM: Fix Virtual File System binding - CMake: Remove unnecessary dependencies
tore-espressif
force-pushed
the
feature/esp_tinyusb/optimize_cdc
branch
from
ce58750
to
cf51490
Compare
Quality update for
esp_tinyusb, focused mostly on CDC driverTested with both 0.14 and 0.15 TinyUSB
TODO: