Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/pedantic build #529

Merged
merged 2 commits into from
Apr 19, 2023
Merged

Conversation

tore-espressif
Copy link
Contributor

This PR fixed pedantic builds and add pedantic flags to CI builds.

Related #526 , espressif/esp-bsp#51

This is required for pedantic builds with
-Wstrict-prototypes flag
@tore-espressif tore-espressif force-pushed the fix/pedantic_build branch 2 times, most recently from eac56a2 to b95afb6 Compare April 19, 2023 10:08
@me-no-dev
Copy link
Member

It's now failing because of IDF 4.2. Maybe there is a way to enforce the flags only for this component?

@tore-espressif
Copy link
Contributor Author

It's now failing because of IDF 4.2. Maybe there is a way to enforce the flags only for this component?

Unfortunately, I didn't find a way how to do this without modifying CMakeLists.txt... So I split the build into two jobs:

  1. Regular for IDF v4.1-4.3
  2. Pedantic for IDF v4.4-latest

@me-no-dev me-no-dev merged commit fac9509 into espressif:master Apr 19, 2023
@tore-espressif tore-espressif deleted the fix/pedantic_build branch April 19, 2023 20:20
@tore-espressif
Copy link
Contributor Author

@me-no-dev Is it possible to push new tag v2.0.4 so the changes are uploaded to IDF component registry?

@me-no-dev
Copy link
Member

I will as soon as #525 is ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants