-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nan_console): Error when NAN Discovery is started more than once (IDFGH-13923) #14762
base: master
Are you sure you want to change the base?
Conversation
👋 Hello entrop1a, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
08dad37
to
83ec999
Compare
d8787d6
to
4301645
Compare
@entrop1a , thanks for your contribution, with the minor modification mentioned above, will take the PR for internal review |
@nachiketkukade, thanks for your review! Modifications have been made. |
Description
In nan_console example, when NAN is started more than once, triggers this netif error:
esp_netif_lwip: esp_netif_new_api: Failed to configure netif with config=0x3ffc85e0 (config or if_key is NULL or duplicate key)
. This means that the existence of a created network interface was not checked.To resolve this problem, three actions were taken:
g_nan_netif
;g_nan_netif
is checked;g_nan_netif
gets NULL.Testing
Error log:
Fixed log: