Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(esp_http_client): Add function to delete all headers set by 'esp_http_client_set_header' (IDFGH-13628) #14512

Closed
wants to merge 1 commit into from

Conversation

DCSBL
Copy link
Contributor

@DCSBL DCSBL commented Sep 5, 2024

Related to https://esp32.com/viewtopic.php?f=13&t=41695. TL;DR: Headers by persistent sessions created by esp_http_client_init are kept, and it is not easy to remove all headers unless you keep track of which one you set.

This PR adds a function that wraps the already existing http_header_clean function to help with that.

We still mis cleanup functions for other esp_http_client_set_* functions, but lets discuss this idea first :)

Copy link

github-actions bot commented Sep 5, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello DCSBL, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 050ef87

@DCSBL DCSBL marked this pull request as ready for review September 5, 2024 10:36
@DCSBL
Copy link
Contributor Author

DCSBL commented Sep 5, 2024

Note: I was unable to find unit tests for esp_http_client_delete_header so I did not add a unit test for this new feature.

@espressif-bot espressif-bot added the Status: Opened Issue is new label Sep 5, 2024
@github-actions github-actions bot changed the title feat(esp_http_client): Add function to delete all headers set by 'esp_http_client_set_header' feat(esp_http_client): Add function to delete all headers set by 'esp_http_client_set_header' (IDFGH-13628) Sep 5, 2024
@nileshkale123
Copy link
Collaborator

sha=050ef874eac3c07112a42440e793cf0cfa67aa57

@nileshkale123 nileshkale123 added the PR-Sync-Merge Pull request sync as merge commit label Sep 25, 2024
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: Opened Issue is new labels Sep 29, 2024
@Alvin1Zhang
Copy link
Collaborator

Thanks for contribution again, changes have been merged with 72f3ef8.

@Alvin1Zhang Alvin1Zhang closed this Oct 8, 2024
@DCSBL DCSBL deleted the add-http-header-delete-all branch October 8, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants