-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep export.sh Bourne Shell compatible (IDFGH-11073) #12247
Keep export.sh Bourne Shell compatible (IDFGH-11073) #12247
Conversation
Hi @panduit-mik , Thank you for your contribution. In addition, $OSTYPE is not recognized by the original Bourne shell, so it would not fix your problem. Please use newer shells like bash, dash, zsh etc.. Let me know, if you find better working solution. |
Some build environments (like yocto), use bourne shell for widest compatibility which is why it would be better to continue to keep this script bourne shell compatible.
Note also that $OSTYPE is also not recognized by dash on some platforms But uname is really the best most portable way to differentiate Unix OS flavors.
|
@panduit-mik Could you update this pull request in accordance with your latest comment? This will enable me to carry out testing and proceed with the merge. If not, we will close this pull request and revisit your changes at a later time. |
👋 Welcome panduit-mik, thank you for your first contribution to 📘 Please check Contributions Guide for the contribution checklist, information regarding code and documentation style, testing and other topics. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for espressif/esp-idf project. Pull request review and merge process you can expectEspressif develops the ESP-IDF project in an internal repository (Gitlab). We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.
🔁 You can re-run automatic PR checks by retrying the DangerJS action |
@panduit-mik Thank you! And last, please squash all commits into one since it is one change. |
The '[[' operator is not supported by /bin/sh
Use '[' instead to keep it compatible.