Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adc: fix adc dma interrupt stops under heavy load (IDFGH-10863) #12065

Closed
wants to merge 1 commit into from
Closed

adc: fix adc dma interrupt stops under heavy load (IDFGH-10863) #12065

wants to merge 1 commit into from

Conversation

puyoulu
Copy link

@puyoulu puyoulu commented Aug 12, 2023

The adc rx dma eof interrupt will stop generating after all rx eof descriptor is owered by DMA engine. This may happen under heavy load (eg. wifi initialization), and eof_desc_addr should not be used to check the current eof descriptor anymore (for there maybe long delays during adc_dma_intr_handler execution).
Fix this by disabling owner check of descriptor in the DMA engine side, and CPU determines valid eof descriptor by polling the owner bit.

closing #12053

@CLAassistant
Copy link

CLAassistant commented Aug 12, 2023

CLA assistant check
All committers have signed the CLA.

@espressif-bot espressif-bot added the Status: Opened Issue is new label Aug 12, 2023
@github-actions github-actions bot changed the title adc: fix adc dma interrupt stops under heavy load adc: fix adc dma interrupt stops under heavy load (IDFGH-10863) Aug 12, 2023
The adc rx dma eof interrupt will stop generating after all rx eof
descriptor is owered by DMA engine. This may happen under heavy load
(eg. wifi initialization).
Fix this by disabling owner check of descriptor in the DMA engine
side, and CPU determines valid eof descriptor by polling the owner bit.
@Alvin1Zhang
Copy link
Collaborator

Thanks for your contribution.

@puyoulu puyoulu closed this by deleting the head repository Sep 12, 2023
@railbox
Copy link

railbox commented Oct 1, 2023

Any reason why this was closed? Looks like it resolve same bug in my case too.

@Icarus113
Copy link
Collaborator

Any reason why this was closed? Looks like it resolve same bug in my case too.

A PR with similar changes have been accepted before. You may upgrade to use a newer version.

@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: Opened Issue is new labels Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants