Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rx_buffer type in TCP example (IDFGH-10780) #11992

Closed
wants to merge 2 commits into from

Conversation

Daniel-Chin
Copy link

In the example projects for protocol/socket/TCP..., the rx_buffer was of type char*. I changed it to uint8_t*.

Semantically, TCP transmits a byte stream, not a char stream. Using char* in the example can potentially confuse beginners.

Let me know if there are further considerations.

@CLAassistant
Copy link

CLAassistant commented Aug 1, 2023

CLA assistant check
All committers have signed the CLA.

@espressif-bot espressif-bot added the Status: Opened Issue is new label Aug 1, 2023
@github-actions github-actions bot changed the title Fix rx_buffer type in TCP example Fix rx_buffer type in TCP example (IDFGH-10780) Aug 1, 2023
@espressif-abhikroy
Copy link
Collaborator

I concur with your assessment regarding a standard TCP connection. However, in the context of this specific example, the payload has been hardcoded as an ASCII string. Therefore, the present implementation is accurate and does not require any alterations.

@espressif-bot espressif-bot added Status: Reviewing Issue is being reviewed Status: Opened Issue is new and removed Status: Opened Issue is new Status: Reviewing Issue is being reviewed labels Sep 15, 2023
@Daniel-Chin
Copy link
Author

I concur with your assessment regarding a standard TCP connection. However, in the context of this specific example, the payload has been hardcoded as an ASCII string. Therefore, the present implementation is accurate and does not require any alterations.

Understood.

@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: Won't Do This will not be worked on and removed Status: Opened Issue is new labels Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Won't Do This will not be worked on Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants