feat(nvs_flash): nvs_gen_partition_image CMake function (IDFGH-10542) #11785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
nebkat
force-pushed
the
codespace-nebkat-studious-enigma-pjrq9gp73777
branch
from
0cd9585
to
13077ed
Compare
nebkat
force-pushed
the
codespace-nebkat-studious-enigma-pjrq9gp73777
branch
from
13077ed
to
c5b11f2
Compare
|
@nebkat Thanks for this useful feature! The code looks good to me so far, please ping when you think this PR is ready. |
|
Can we move forward with any of the two PRs? Personally, I like my function name better because it's almost identical to the SPIFFS one. But in the end I really don't care, just pick one or provide feedback for further improvements please. |
espressif-bot
added
Status: Selected for Development
espressif-bot
added
Status: In Progress
espressif-bot
added
Status: Done
adokitkat
added
Resolution: Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a CMake function
nvs_gen_partition_imagesimilar tospiffs_create_partition_image.Will add examples and documentation shortly.