Return error code instead of crashing on failed initialization (EHM-106) #103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the behavior of the esp_hosted_init function to return an esp_err_t error code instead of crashing by asserting using the ESP_ERROR_CHECK macro.
Related
The macro ESP_ERROR_CHECK is used often in Espressif code, as a user I would like it a lot if the use of this macro and asserts in general could be limited to an absolute minimum. If a function signature suggests an error code gets returned on failure then please do so instead of crashing.
In this particular case I would like to implement a recovery procedure or show a proper error message to the user when the Espressif API returns an error code. The use of ESP_ERROR_CHECK makes this impossible.
Testing
Tested on our product consisting of an ESP32-P4 and ESP32-C6 connected using SDIO.
Checklist
Before submitting a Pull Request, please ensure the following: