Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(uart): Set back Pin signal polarity #9950

Merged
merged 3 commits into from
Jul 1, 2024
Merged

fix(uart): Set back Pin signal polarity #9950

merged 3 commits into from
Jul 1, 2024

Conversation

SuGlider
Copy link
Collaborator

Description of Change

Fixes a problem related to inverting signal polarity back to normal after a previous inversion.
This shall set the correct polarity in Serial.begin().

Tests scenarios

#include <Arduino.h>
#include <HardwareSerial.h>

HardwareSerial serial(0);   // use serial(1) for comparison

void setup() {}

void loop() {
  serial.begin(115200, SERIAL_8N1, 3, 1, false);
  serial.write("hello");
  serial.flush();
  serial.end();

  serial.begin(115200, SERIAL_8N1, 3, 1, true);
  serial.write("hello");
  serial.flush();
  serial.end();
}

Related links

Fix #9896

@SuGlider
fix(uart): Set back Pin signal polarity
adae99f 
Fixes a problem related to inverting signal polarity back to normal after a previous inversion.

This shall set the correct polarity in Serial.begin().
@SuGlider SuGlider added this to the 3.0.3 milestone Jun 28, 2024
@SuGlider SuGlider self-assigned this Jun 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 28, 2024 •
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "fix(uart): Update comment":
    • summary looks too short

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).
Messages
📖 You might consider squashing your 3 commits (simplifying branch history).

👋 Hello SuGlider, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against f023b27

@SuGlider SuGlider marked this pull request as draft June 28, 2024 14:45
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 28, 2024 •
edited
Loading

Test Results

 56 files  ±0   56 suites  ±0   5m 3s ⏱️ -1s
 21 tests ±0   21 ✅ ±0  0 💤 ±0  0 ❌ ±0 
135 runs  ±0  135 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f023b27. ± Comparison against base commit 337058a.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S30⚠️ +320.000.00000.000.00
ESP32S2💚 -12⚠️ +120.000.00000.000.00
ESP32C30⚠️ +20.000.00000.000.00
ESP32C60⚠️ +20.000.00000.000.00
ESP32H20⚠️ +20.000.00000.000.00
ESP32💚 -16⚠️ +120.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
ArduinoOTA/examples/BasicOTA⚠️ +40💚 -40⚠️ +20⚠️ +20--00
AsyncUDP/examples/AsyncUDPClient⚠️ +40⚠️ +120⚠️ +20⚠️ +20--00
AsyncUDP/examples/AsyncUDPMulticastServer⚠️ +40💚 -40⚠️ +20⚠️ +20--00
AsyncUDP/examples/AsyncUDPServer⚠️ +40💚 -40⚠️ +20⚠️ +20--00
BLE/examples/BLE5_extended_scan⚠️ +40--⚠️ +20⚠️ +20⚠️ +20--
BLE/examples/BLE5_multi_advertising⚠️ +40--⚠️ +20⚠️ +20⚠️ +20--
BLE/examples/BLE5_periodic_advertising⚠️ +160--⚠️ +20⚠️ +20⚠️ +20--
BLE/examples/BLE5_periodic_sync⚠️ +40--⚠️ +20⚠️ +20⚠️ +20--
BLE/examples/Beacon_Scanner⚠️ +40--⚠️ +20⚠️ +20⚠️ +2000
BLE/examples/Client⚠️ +40--⚠️ +20⚠️ +20⚠️ +2000
BLE/examples/EddystoneTLM_Beacon⚠️ +40--⚠️ +20⚠️ +20--00
BLE/examples/EddystoneURL_Beacon⚠️ +40--⚠️ +20⚠️ +20--00
BLE/examples/Notify⚠️ +40--⚠️ +20⚠️ +20⚠️ +20💚 -120
BLE/examples/Scan⚠️ +40--⚠️ +20⚠️ +20⚠️ +2000
BLE/examples/Server⚠️ +40--⚠️ +20⚠️ +20⚠️ +2000
BLE/examples/Server_multiconnect⚠️ +40--⚠️ +20⚠️ +20⚠️ +20⚠️ +120
BLE/examples/UART⚠️ +40--⚠️ +20⚠️ +20⚠️ +2000
BLE/examples/Write⚠️ +40--⚠️ +20⚠️ +20⚠️ +20💚 -40
BLE/examples/iBeacon⚠️ +40--⚠️ +20⚠️ +20⚠️ +2000
DNSServer/examples/CaptivePortal⚠️ +40💚 -40⚠️ +20⚠️ +20--💚 -120
EEPROM/examples/eeprom_class⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
EEPROM/examples/eeprom_extra⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
EEPROM/examples/eeprom_write⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/AnalogOut/LEDCFade⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/AnalogOut/LEDCSoftwareFade000000000000
ESP32/examples/AnalogOut/SigmaDelta000000000000
ESP32/examples/AnalogOut/ledcFrequency000000000000
ESP32/examples/AnalogOut/ledcWrite_RGB⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/AnalogRead⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/AnalogReadContinuous⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/ArduinoStackSize⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/CI/CIBoardsTest⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/Camera/CameraWebServer⚠️ +40💚 -40------00
ESP32/examples/ChipID/GetChipID⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/DeepSleep/ExternalWakeUp⚠️ +40💚 -40------00
ESP32/examples/DeepSleep/TimerWakeUp⚠️ +40💚 -40⚠️ +20⚠️ +20--00
ESP32/examples/DeepSleep/TouchWakeUp⚠️ +40💚 -40------00
ESP32/examples/FreeRTOS/BasicMultiThreading⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/FreeRTOS/Mutex⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/FreeRTOS/Queue⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/FreeRTOS/Semaphore⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/GPIO/BlinkRGB000000000000
ESP32/examples/GPIO/FunctionalInterrupt⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/GPIO/FunctionalInterruptStruct⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/GPIO/GPIOInterrupt⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/HWCDC_Events00--⚠️ +20⚠️ +20⚠️ +20--
ESP32/examples/MacAddress/GetMacAddress⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/RMT/Legacy_RMT_Driver_Compatible⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/RMT/RMTCallback⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/RMT/RMTLoopback⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/RMT/RMTReadXJT⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/RMT/RMTWriteNeoPixel⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/RMT/RMT_CPUFreq_Test⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/RMT/RMT_EndOfTransmissionState⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/RMT/RMT_LED_Blink⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/ResetReason/ResetReason⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/ResetReason/ResetReason2⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/Serial/BaudRateDetect_Demo⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/Serial/OnReceiveError_BREAK_Demo⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/Serial/OnReceive_Demo⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/Serial/RS485_Echo_Demo⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/Serial/RxFIFOFull_Demo⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/Serial/RxTimeout_Demo⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/Serial/Serial_All_CPU_Freqs⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/Serial/Serial_STD_Func_OnReceive⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/Serial/onReceiveExample⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/TWAI/TWAIreceive⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/TWAI/TWAItransmit⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/Template/ExampleTemplate000000000000
ESP32/examples/Time/SimpleTime⚠️ +40💚 -40⚠️ +20⚠️ +20--00
ESP32/examples/Timer/RepeatTimer⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/Timer/WatchdogTimer⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/Touch/TouchButtonV2⚠️ +40💚 -40--------
ESP32/examples/Touch/TouchInterrupt⚠️ +40💚 -40------00
ESP32/examples/Touch/TouchRead⚠️ +40💚 -40------00
ESP32/examples/Utilities/HEXBuilder⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/Utilities/MD5Builder⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP32/examples/Utilities/SHA1Builder⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP_I2S/examples/ES8388_loopback⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP_I2S/examples/Record_to_WAV⚠️ +40--------00
ESP_I2S/examples/Simple_tone⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
ESP_NOW/examples/ESP_NOW_Broadcast_Master⚠️ +40💚 -40⚠️ +20⚠️ +20--00
ESP_NOW/examples/ESP_NOW_Broadcast_Slave⚠️ +40💚 -40⚠️ +20⚠️ +20--00
ESP_NOW/examples/ESP_NOW_Network⚠️ +40💚 -120⚠️ +20⚠️ +20--00
ESP_NOW/examples/ESP_NOW_Serial⚠️ +40💚 -40⚠️ +20⚠️ +20--00
ESP_SR/examples/Basic⚠️ +40----------
ESPmDNS/examples/mDNS-SD_Extended⚠️ +120💚 -40⚠️ +20⚠️ +20--00
ESPmDNS/examples/mDNS_Web_Server⚠️ +40💚 -40⚠️ +20⚠️ +20--💚 -120
Ethernet/examples/ETH_W5500_Arduino_SPI⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
Ethernet/examples/ETH_W5500_IDF_SPI0000⚠️ +20⚠️ +20⚠️ +2000
FFat/examples/FFat_Test⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
FFat/examples/FFat_time⚠️ +40💚 -40⚠️ +20⚠️ +20--00
HTTPClient/examples/Authorization⚠️ +40💚 -40⚠️ +20⚠️ +20--💚 -120
HTTPClient/examples/BasicHttpClient⚠️ +40💚 -40⚠️ +20⚠️ +20--💚 -120
HTTPClient/examples/BasicHttpsClient⚠️ +4000⚠️ +20⚠️ +20--00
HTTPClient/examples/HTTPClientEnterprise⚠️ +4000⚠️ +20⚠️ +20--00
HTTPClient/examples/ReuseConnection⚠️ +40💚 -40⚠️ +20⚠️ +20--💚 -120
HTTPClient/examples/StreamHttpClient⚠️ +40💚 -40⚠️ +20⚠️ +20--00
HTTPUpdate/examples/httpUpdate⚠️ +4000⚠️ +20⚠️ +20--00
HTTPUpdate/examples/httpUpdateSPIFFS⚠️ +40💚 -40⚠️ +20⚠️ +20--00
HTTPUpdate/examples/httpUpdateSecure⚠️ +40💚 -40⚠️ +20⚠️ +20--00
HTTPUpdateServer/examples/WebUpdater⚠️ +40💚 -40⚠️ +20⚠️ +20--00
Insights/examples/DiagnosticsSmokeTest⚠️ +40💚 -40⚠️ +20----00
Insights/examples/MinimalDiagnostics⚠️ +40💚 -40⚠️ +20----00
LittleFS/examples/LITTLEFS_test⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
LittleFS/examples/LITTLEFS_time⚠️ +40💚 -40⚠️ +20⚠️ +20--00
NetBIOS/examples/ESP_NBNST⚠️ +40💚 -40⚠️ +20⚠️ +20--00
NetworkClientSecure/examples/WiFiClientInsecure⚠️ +40💚 -40⚠️ +20⚠️ +20--00
NetworkClientSecure/examples/WiFiClientPSK⚠️ +40💚 -40⚠️ +20⚠️ +20--00
NetworkClientSecure/examples/WiFiClientSecure⚠️ +40💚 -40⚠️ +20⚠️ +20--00
NetworkClientSecure/examples/WiFiClientSecureEnterprise⚠️ +40💚 -40⚠️ +20⚠️ +20--💚 -120
NetworkClientSecure/examples/WiFiClientSecureProtocolUpgrade⚠️ +40💚 -40⚠️ +20⚠️ +20--00
NetworkClientSecure/examples/WiFiClientShowPeerCredentials⚠️ +40💚 -40⚠️ +20⚠️ +20--00
NetworkClientSecure/examples/WiFiClientTrustOnFirstUse⚠️ +4000⚠️ +20⚠️ +20--00
PPP/examples/PPP_Basic⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
Preferences/examples/Prefs2Struct⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
Preferences/examples/StartCounter⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
RainMaker/examples/RMakerCustom⚠️ +40💚 -40⚠️ +20----00
RainMaker/examples/RMakerCustomAirCooler⚠️ +40💚 -40⚠️ +20----00
RainMaker/examples/RMakerSonoffDualR3⚠️ +40💚 -40⚠️ +20----00
RainMaker/examples/RMakerSwitch⚠️ +40💚 -40⚠️ +20----00
SD/examples/SD_Test⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
SD/examples/SD_time⚠️ +40💚 -40⚠️ +20⚠️ +20--💚 -120
SD_MMC/examples/SD2USBMSC⚠️ +40----------
SD_MMC/examples/SDMMC_Test⚠️ +40--------00
SD_MMC/examples/SDMMC_time⚠️ +40--------00
SPI/examples/SPI_Multiple_Buses0000------00
SPIFFS/examples/SPIFFS_Test⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
SPIFFS/examples/SPIFFS_time⚠️ +40💚 -40⚠️ +20⚠️ +20--00
SimpleBLE/examples/SimpleBleDevice⚠️ +40----⚠️ +20⚠️ +2000
TFLiteMicro/examples/hello_world000000000000
Ticker/examples/Blinker000000000000
Ticker/examples/TickerBasic000000000000
Ticker/examples/TickerParameter000000000000
USB/examples/CompositeDevice⚠️ +40💚 -40--------
USB/examples/ConsumerControl0000--------
USB/examples/CustomHIDDevice⚠️ +40💚 -40--------
USB/examples/FirmwareMSC⚠️ +40💚 -40--------
USB/examples/Gamepad⚠️ +40💚 -40--------
USB/examples/HIDVendor⚠️ +40💚 -40--------
USB/examples/Keyboard/KeyboardLogout0000--------
USB/examples/Keyboard/KeyboardMessage0000--------
USB/examples/Keyboard/KeyboardReprogram0000--------
USB/examples/Keyboard/KeyboardSerial⚠️ +40💚 -40--------
USB/examples/KeyboardAndMouseControl⚠️ +40💚 -40--------
USB/examples/MIDI/MidiController⚠️ +40💚 -40--------
USB/examples/MIDI/MidiInterface⚠️ +40💚 -40--------
USB/examples/MIDI/MidiMusicBox⚠️ +40💚 -40--------
USB/examples/MIDI/ReceiveMidi⚠️ +40💚 -40--------
USB/examples/Mouse/ButtonMouseControl0000--------
USB/examples/SystemControl0000--------
USB/examples/USBMSC⚠️ +40💚 -40--------
USB/examples/USBSerial⚠️ +40💚 -40--------
USB/examples/USBVendor⚠️ +40💚 -40--------
Update/examples/AWS_S3_OTA_Update⚠️ +40💚 -40⚠️ +20⚠️ +20--00
Update/examples/HTTPS_OTA_Update00💚 -40⚠️ +20⚠️ +20--00
Update/examples/HTTP_Client_AES_OTA_Update⚠️ +40💚 -40⚠️ +20⚠️ +20--00
Update/examples/HTTP_Server_AES_OTA_Update⚠️ +4000⚠️ +20⚠️ +20--00
Update/examples/OTAWebUpdater⚠️ +4000⚠️ +20⚠️ +20--00
Update/examples/SD_Update⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
WebServer/examples/AdvancedWebServer⚠️ +40💚 -40⚠️ +20⚠️ +20--00
WebServer/examples/FSBrowser⚠️ +320💚 -40⚠️ +20⚠️ +20--00
WebServer/examples/Filters⚠️ +40💚 -40⚠️ +20⚠️ +20--00
WebServer/examples/HelloServer⚠️ +40💚 -40⚠️ +20⚠️ +20--00
WebServer/examples/HttpAdvancedAuth⚠️ +40💚 -40⚠️ +20⚠️ +20--00
WebServer/examples/HttpAuthCallback⚠️ +40💚 -40⚠️ +20⚠️ +20--00
WebServer/examples/HttpAuthCallbackInline⚠️ +40💚 -40⚠️ +20⚠️ +20--00
WebServer/examples/HttpBasicAuth⚠️ +40💚 -40⚠️ +20⚠️ +20--00
WebServer/examples/HttpBasicAuthSHA1⚠️ +40💚 -40⚠️ +20⚠️ +20--💚 -120
WebServer/examples/HttpBasicAuthSHA1orBearerToken⚠️ +40💚 -40⚠️ +20⚠️ +20--00
WebServer/examples/MultiHomedServers⚠️ +40💚 -40⚠️ +20⚠️ +20--00
WebServer/examples/PathArgServer⚠️ +40💚 -40⚠️ +20⚠️ +20--00
WebServer/examples/SDWebServer⚠️ +40💚 -40⚠️ +20⚠️ +20--00
WebServer/examples/SimpleAuthentification⚠️ +40💚 -40⚠️ +20⚠️ +20--00
WebServer/examples/UploadHugeFile⚠️ +40💚 -40⚠️ +20⚠️ +20--00
WebServer/examples/WebServer⚠️ +40💚 -40⚠️ +20⚠️ +20--00
WebServer/examples/WebUpdate⚠️ +40💚 -40⚠️ +20⚠️ +20--00
WiFi/examples/FTM/FTM_Initiator⚠️ +40💚 -40⚠️ +20⚠️ +20--00
WiFi/examples/FTM/FTM_Responder⚠️ +40💚 -40⚠️ +20⚠️ +20--00
WiFi/examples/SimpleWiFiServer⚠️ +40💚 -40⚠️ +20⚠️ +20--00
WiFi/examples/WPS⚠️ +40💚 -40⚠️ +20⚠️ +20--00
WiFi/examples/WiFiAccessPoint⚠️ +40💚 -40⚠️ +20⚠️ +20--00
WiFi/examples/WiFiBlueToothSwitch00--⚠️ +20⚠️ +20--00
WiFi/examples/WiFiClient⚠️ +40⚠️ +40⚠️ +20⚠️ +20--00
WiFi/examples/WiFiClientBasic⚠️ +40💚 -40⚠️ +20⚠️ +20--00
WiFi/examples/WiFiClientConnect⚠️ +40💚 -40⚠️ +20⚠️ +20--00
WiFi/examples/WiFiClientEnterprise⚠️ +40💚 -40⚠️ +20⚠️ +20--00
WiFi/examples/WiFiClientEvents⚠️ +40💚 -40⚠️ +20⚠️ +20--00
WiFi/examples/WiFiClientStaticIP⚠️ +40💚 -40⚠️ +20⚠️ +20--⚠️ +120
WiFi/examples/WiFiIPv6⚠️ +40💚 -40⚠️ +20⚠️ +20--00
WiFi/examples/WiFiMulti⚠️ +40💚 -40⚠️ +20⚠️ +20--💚 -160
WiFi/examples/WiFiMultiAdvanced⚠️ +40💚 -40⚠️ +20⚠️ +20--💚 -40
WiFi/examples/WiFiScan⚠️ +40💚 -40⚠️ +20⚠️ +20--00
WiFi/examples/WiFiScanAsync0000⚠️ +20⚠️ +20--00
WiFi/examples/WiFiScanDualAntenna00💚 -40⚠️ +20⚠️ +20--00
WiFi/examples/WiFiSmartConfig⚠️ +40💚 -40⚠️ +20⚠️ +20--00
WiFi/examples/WiFiTelnetToSerial⚠️ +40💚 -40⚠️ +20⚠️ +20--00
WiFi/examples/WiFiUDPClient⚠️ +40💚 -40⚠️ +20⚠️ +20--00
WiFiProv/examples/WiFiProv⚠️ +40💚 -40⚠️ +20⚠️ +20--00
Wire/examples/WireMaster⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
Wire/examples/WireScan⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
Wire/examples/WireSlave⚠️ +40💚 -40⚠️ +20⚠️ +20⚠️ +2000
OpenThread/examples/COAP/coap_lamp------⚠️ +20⚠️ +20--
OpenThread/examples/COAP/coap_switch------⚠️ +20⚠️ +20--
OpenThread/examples/SimpleCLI------⚠️ +20⚠️ +20--
OpenThread/examples/SimpleNode------⚠️ +20⚠️ +20--
OpenThread/examples/SimpleThreadNetwork/LeaderNode------⚠️ +20⚠️ +20--
OpenThread/examples/SimpleThreadNetwork/RouterNode------⚠️ +20⚠️ +20--
OpenThread/examples/ThreadScan------⚠️ +20⚠️ +20--
OpenThread/examples/onReceive------⚠️ +20⚠️ +20--
BluetoothSerial/examples/DiscoverConnect----------00
BluetoothSerial/examples/GetLocalMAC----------00
BluetoothSerial/examples/SerialToSerialBT----------00
BluetoothSerial/examples/SerialToSerialBTM----------00
BluetoothSerial/examples/SerialToSerialBT_Legacy----------00
BluetoothSerial/examples/SerialToSerialBT_SSP----------00
BluetoothSerial/examples/bt_classic_device_discovery----------00
BluetoothSerial/examples/bt_remove_paired_devices----------00
ESP32/examples/DeepSleep/SmoothBlink_ULP_Code----------00
ESP32/examples/Touch/TouchButton----------00
Ethernet/examples/ETH_LAN8720----------00
Ethernet/examples/ETH_TLK110----------00

@SuGlider SuGlider mentioned this pull request Jun 28, 2024
Closed
1 task
@SuGlider SuGlider marked this pull request as ready for review June 28, 2024 16:59
@SuGlider
fix(uart): Remove useless commentary
15bab66 
Removes a commentary with a question about the inversing polarity function.
P-R-O-C-H-Y
P-R-O-C-H-Y reviewed Jul 1, 2024
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SuGlider PTAL

cores/esp32/esp32-hal-uart.c Outdated Show resolved Hide resolved
@me-no-dev @P-R-O-C-H-Y
fix(uart): Update comment
f023b27 
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Jul 1, 2024
@me-no-dev me-no-dev merged commit 5f663e7 into master Jul 1, 2024
69 of 71 checks passed
@me-no-dev me-no-dev deleted the sugliger_uart_polarity branch July 1, 2024 10:11
@mha1 mha1 mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

@me-no-dev me-no-dev me-no-dev approved these changes

@lucasssvaz lucasssvaz Awaiting requested review from lucasssvaz

Assignees

@SuGlider SuGlider

Labels
Peripheral: UART Status: Pending Merge Pull Request is ready to be merged
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
3.0.3
Development

Successfully merging this pull request may close these issues.

invert status never reset on serial0 after having been set to invert once
3 participants
@SuGlider @me-no-dev @P-R-O-C-H-Y