rainmaker: multiple device callbacks not getting registered #8249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@shahpiyushv @vikramdattu PTAL |
vikramdattu
reviewed
May 25, 2023
|
Good day, |
@lishnih I tried this PR with the example you shared in your issue description and it worked fine. Please share your sketch that gives |
|
I withdraw my comment, I tried it again and found out that I defined Switch variable inside setup() therefore I got the exception. With global variable I have no issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR fixes an issue of multiple device callbacks (one callback per device) were not getting registered and invoked.
Consider an example where I create two devices, a switch and a fan; each of them having their own write callbacks. On controlling either switch/fan through Rainmaker app, the callback that got registered at last gets invoked. This is also seen in the issue reported here
Test Scenarios
I have tested this PR by creating four devices; Switch, Lightbulb, Temp. sensor and Fan; each of them having their own callback. On controlling the device through app, respective callbacks were getting invoked.
Related links
Closes #8231