Refactored use of LOG_X(LOG_TAG, ...) to log_x(...) #2672
Conversation
libraries/ESPmDNS/src/ESPmDNS.cpp
Outdated
| @@ -82,7 +82,7 @@ void MDNSResponder::setInstanceName(String name) { | |||
|
|
|||
| void MDNSResponder::enableArduino(uint16_t port, bool auth){ | |||
| mdns_txt_item_t arduTxtData[4] = { | |||
| {(char*)"board" ,(char*)ARDUINO_VARIANT}, | |||
| {(char*)"board" ,(char*)"esp32"}, | |||
There was a problem hiding this comment.
This should be reverted, the ARDUINO_VARIANT variable is injected with the board name typically. The ESPmDNS library checks explicitly for this define and if missing defines it itself as you have done here: https://github.com/espressif/arduino-esp32/blob/master/libraries/ESPmDNS/src/ESPmDNS.h#L48-L51
There was a problem hiding this comment.
yeah, why would you change that?
There was a problem hiding this comment.
I don't know why all these commits are part of this pull request, these are from months ago, and already reverted locally.
It also looks like that code isn't there anymore
|
Is this refactoring really necessary? It is now broken. If the kconfig does not select CONFIG_ARDUHAL_ESP_LOG (ESP Log forwarding to Arduino Log) then Previously, if you wanted forwarding then EDIT: My apologies..I missed that this was fixed right after v3.2 tag there is a commit to fix the |
|
this is an Arduino library and will always have CONFIG_ARDUHAL_ESP_LOG defined :) includes will be there and all. What is your use case? |
LOG_TAG is not used in implementation of logging