Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove useless condition in if statement #2371

Merged
merged 4 commits into from
Feb 14, 2019
Merged

Conversation

acevest
Copy link
Contributor

@acevest acevest commented Jan 23, 2019

uint8_t run() {
    if(status != WL_CONNECTED || status == WL_NO_SSID_AVAIL || status == WL_IDLE_STATUS || status == WL_CONNECT_FAILED) {
        // ...
    }
}

these code are equal to

uint8_t run() {
    if(status != WL_CONNECTED) {
        // ...
    }
}

and equal to

uint8_t run() {
    if(status == WL_CONNECTED) {
        return status;
    }

    // ...
}

@me-no-dev me-no-dev merged commit aa2393b into espressif:master Feb 14, 2019
@me-no-dev
Copy link
Member

thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants