Fix BananaPi-BIT and T-Beam pin definitions #2343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in https://github.com/OttoWinter/esphomeyaml/pull/355/files#diff-e852becfc54c4ff8a3bf897c6afc323cR134
The BananaPi-BIT and TTGO T-Beam pin definitions seem to have a copy and paste error (like this one: #1949)
Original BananaPi PR: #1810
Original T-Beam PR: #1852
Disclaimer: I don't own any of these boards, the pin definitions just look a lot like a copy and paste error that has been copied through (and fixed in #1949) - also I don't think it's possible to re-map the touch & DAC pins :)
CC @yelvlab, @lewisxhe