-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update lib - User can choose if calc MD5 from encrypted or decrypted file #10510
Conversation
At the present moment, if user want use OTA, the function calculate MD5 of the decrypted file, but if file is encrypted from source, could be more useful to know the MD5 of the encrypted file.
👋 Hello zinkett, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
@zinkett - Please electronically sign the CLA using your Github username, if you agree to it. |
Test Results 56 files 56 suites 4m 8s ⏱️ Results for commit 120edca. ♻️ This comment has been updated with latest results. |
@zinkett - There are some compilation error within this PR (pointed by CI). Please check it at https://github.com/espressif/arduino-esp32/actions/runs/11479892688/job/31957134561?pr=10510 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @lucasssvaz
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of Change
I'm using OTA with pre-encrypted bin file.
So it's easy to calculate the MD5 of the encrypted file before send it to device.
Update function at the moment is calculating the MD5 of the decrypted file.
With this commit with
Update.setMD5(md5, false);
the check of MD5 will be done of encrypted file. Otherwise it will be calculate of the decrypted file.
Tests scenarios
I have tested my Pull Request on Arduino-esp32 core v3.0.6 with ESP32