Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(example): print correct fade direction #10450

Merged
merged 3 commits into from
Oct 17, 2024
Merged

fix(example): print correct fade direction #10450

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7fa14cc
fix(example): print correct fade direction
P-R-O-C-H-Y Oct 11, 2024
dad3cb3
fix(example): Change to fade in out
P-R-O-C-H-Y Oct 11, 2024
c21ff28
fix(example): Codespell fix
P-R-O-C-H-Y Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions libraries/ESP32/examples/AnalogOut/LEDCFade/LEDCFade.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
#define LEDC_FADE_TIME (3000)

bool fade_ended = false; // status of LED fade
bool fade_on = true;
bool fade_in = true;

void ARDUINO_ISR_ATTR LED_FADE_ISR() {
fade_ended = true;
Expand Down Expand Up @@ -55,15 +55,15 @@ void loop() {
Serial.println("LED fade ended");
fade_ended = false;

// Check if last fade was fade on
if (fade_on) {
// Check what fade should be started next
if (fade_in) {
ledcFadeWithInterrupt(LED_PIN, LEDC_START_DUTY, LEDC_TARGET_DUTY, LEDC_FADE_TIME, LED_FADE_ISR);
Serial.println("LED Fade off started.");
fade_on = false;
Serial.println("LED Fade in started.");
fade_in = false;
} else {
ledcFadeWithInterrupt(LED_PIN, LEDC_TARGET_DUTY, LEDC_START_DUTY, LEDC_FADE_TIME, LED_FADE_ISR);
Serial.println("LED Fade on started.");
fade_on = true;
Serial.println("LED Fade out started.");
fade_in = true;
}
}
}
Loading