Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds setToneChannel() implementation #10305

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Adds setToneChannel() implementation #10305

merged 1 commit into from
Sep 9, 2024

Conversation

SuGlider
Copy link
Collaborator

@SuGlider SuGlider commented Sep 6, 2024 •
edited
Loading

Description of Change

Implements setToneChannel() declared in Arduino.h, but removed when moving from Arduino 2.x to 3.x.
Fixes a Task priority problem in the code. Previous priority was the same of the Arduino Task and it prevents the Tone Queue to be processed before Tone commands are executed.

Tests scenarios

Tested using ESP32-S3, checking the logs.

void setup() {
  setToneChannel(5);
  test();
}

void loop() {
}

void test() {
  // turn off tone function for pin 8:
  noTone(8);
  setToneChannel(1);
  // play a note on pin 6 for 200 ms:
  tone(6, 440, 200);
  delay(200);

  // turn off tone function for pin 6:
  noTone(6);
  setToneChannel(2);
  // play a note on pin 7 for 500 ms:
  tone(7, 494, 500);
  delay(500);

  // turn off tone function for pin 7:
  noTone(7);
  setToneChannel(1);
  // play a note on pin 8 for 300 ms:
  tone(8, 523, 300);
  delay(300);
}

Log:

[   589][D][Tone.cpp:103] noTone(): noTone was called
[   594][E][Tone.cpp:116] noTone(): Tone is not running on given pin 8
[   600][D][Tone.cpp:126] tone(): pin=6, frequency=440 Hz, duration=200 ms
[   607][V][Tone.cpp:74] tone_init(): Creating tone queue
[   612][V][Tone.cpp:80] tone_init(): Tone queue created
[   617][V][Tone.cpp:84] tone_init(): Creating tone task
[   622][V][Tone.cpp:97] tone_init(): Tone task created
[   627][D][Tone.cpp:37] tone_task(): Task received from queue TONE_START: pin=6, frequency=440 Hz, duration=200 ms
[   638][V][esp32-hal-periman.c:235] perimanSetBusDeinit(): Deinit function for type LEDC (9) successfully set to 0x42002574
[   649][V][esp32-hal-periman.c:160] perimanSetPinBus(): Pin 6 successfully set to type LEDC (9) with bus 0x3fcedacc
[   659][I][esp32-hal-ledc.c:151] ledcAttachChannel(): LEDC attached to pin 6 (channel 1, resolution 10)
[   868][D][Tone.cpp:103] noTone(): noTone was called
[   873][D][Tone.cpp:61] tone_task(): Task received from queue TONE_END: pin=6
[   880][V][esp32-hal-periman.c:160] perimanSetPinBus(): Pin 6 successfully set to type INIT (0) with bus 0x0
[   890][D][Tone.cpp:126] tone(): pin=7, frequency=494 Hz, duration=500 ms
[   897][D][Tone.cpp:37] tone_task(): Task received from queue TONE_START: pin=7, frequency=494 Hz, duration=500 ms
[   907][V][esp32-hal-periman.c:235] perimanSetBusDeinit(): Deinit function for type LEDC (9) successfully set to 0x42002574
[   918][V][esp32-hal-periman.c:160] perimanSetPinBus(): Pin 7 successfully set to type LEDC (9) with bus 0x3fcedacc
[   928][I][esp32-hal-ledc.c:151] ledcAttachChannel(): LEDC attached to pin 7 (channel 2, resolution 10)
[  1437][D][Tone.cpp:103] noTone(): noTone was called
[  1442][D][Tone.cpp:61] tone_task(): Task received from queue TONE_END: pin=7
[  1449][V][esp32-hal-periman.c:160] perimanSetPinBus(): Pin 7 successfully set to type INIT (0) with bus 0x0
[  1459][D][Tone.cpp:126] tone(): pin=8, frequency=523 Hz, duration=300 ms
[  1466][D][Tone.cpp:37] tone_task(): Task received from queue TONE_START: pin=8, frequency=523 Hz, duration=300 ms
[  1476][V][esp32-hal-periman.c:235] perimanSetBusDeinit(): Deinit function for type LEDC (9) successfully set to 0x42002574
[  1487][V][esp32-hal-periman.c:160] perimanSetPinBus(): Pin 8 successfully set to type LEDC (9) with bus 0x3fcedacc
[  1497][I][esp32-hal-ledc.c:151] ledcAttachChannel(): LEDC attached to pin 8 (channel 1, resolution 10)

Related links

Closes #10297

@SuGlider
feat(tone): missing set tone channel implementation
d10ea95 
Adds the implementation to setToneChannel() declared in Arduino.h, but removed when movin from Arduino 2.x to 3.x.
@SuGlider SuGlider added this to the 3.0.5 milestone Sep 6, 2024
@SuGlider SuGlider self-assigned this Sep 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024 •
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "feat(tone): missing set tone channel implementation":
    • body's lines must not be longer than 100 characters

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello SuGlider, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against d10ea95

@SuGlider SuGlider mentioned this pull request Sep 6, 2024
Closed
1 task
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024 •
edited
Loading

Test Results

 56 files   -  83   56 suites   - 83   4m 54s ⏱️ - 1h 37m 54s
 21 tests  -   9   21 ✅  -   9  0 💤 ±0  0 ❌ ±0 
135 runs   - 168  135 ✅  - 168  0 💤 ±0  0 ❌ ±0 

Results for commit d10ea95. ± Comparison against base commit e70f4d3.

This pull request removes 9 tests. 
performance.coremark.test_coremark ‑ test_coremark
performance.fibonacci.test_fibonacci ‑ test_fibonacci
performance.psramspeed.test_psramspeed ‑ test_psramspeed
performance.ramspeed.test_ramspeed ‑ test_ramspeed
performance.superpi.test_superpi ‑ test_superpi
test_touch_errors
test_touch_interrtupt
test_touch_read
validation.periman.test_periman ‑ test_periman

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S3💚 -557K‼️ +2104K💚 -30.72‼️ +219.46💚 -25K‼️ +25K💚 -38.58‼️ +71.62
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3
ExampleFLASHRAM
ArduinoOTA/examples/BasicOTA‼️ +29K‼️ +3K
AsyncUDP/examples/AsyncUDPClient‼️ +48K‼️ +3K
AsyncUDP/examples/AsyncUDPMulticastServer‼️ +48K‼️ +3K
AsyncUDP/examples/AsyncUDPServer‼️ +48K‼️ +3K
BLE/examples/BLE5_extended_scan‼️ +212K💚 -8K
BLE/examples/BLE5_multi_advertising‼️ +213K💚 -8K
BLE/examples/BLE5_periodic_advertising‼️ +213K💚 -8K
BLE/examples/BLE5_periodic_sync‼️ +212K💚 -8K
BLE/examples/Beacon_Scanner‼️ +198K💚 -6K
BLE/examples/Client‼️ +198K💚 -6K
BLE/examples/EddystoneTLM_Beacon‼️ +196K💚 -6K
BLE/examples/EddystoneURL_Beacon‼️ +196K💚 -6K
BLE/examples/Notify‼️ +55K💚 -7K
BLE/examples/Scan‼️ +213K💚 -8K
DNSServer/examples/CaptivePortal‼️ +71K‼️ +7K
EEPROM/examples/eeprom_class‼️ +35K‼️ +7K
EEPROM/examples/eeprom_extra‼️ +3K💚 -888
EEPROM/examples/eeprom_write‼️ +35K‼️ +7K
ESP32/examples/AnalogOut/LEDCFade‼️ +35K‼️ +7K
ESP32/examples/AnalogOut/LEDCSingleChannel‼️ +35K‼️ +7K
ESP32/examples/AnalogOut/LEDCSoftwareFade‼️ +35K‼️ +7K
ESP32/examples/AnalogOut/SigmaDelta‼️ +34K‼️ +7K
ESP32/examples/AnalogOut/ledcFrequency‼️ +35K‼️ +7K
BLE/examples/Server‼️ +16K💚 -2K
BLE/examples/Server_multiconnect‼️ +16K💚 -2K
BLE/examples/UART‼️ +16K💚 -2K
BLE/examples/Write‼️ +198K💚 -6K
BLE/examples/iBeacon‼️ +198K💚 -6K
ESP32/examples/AnalogOut/ledcWrite_RGB‼️ +4K💚 -920
ESP32/examples/AnalogRead‼️ +6K💚 -768
ESP32/examples/AnalogReadContinuous⚠️ +1506💚 -912
ESP32/examples/ArduinoStackSize‼️ +3K💚 -888
ESP32/examples/CI/CIBoardsTest‼️ +5K💚 -960
ESP32/examples/Camera/CameraWebServer‼️ +69K‼️ +7K
ESP32/examples/ChipID/GetChipID⚠️ +1150💚 -896
ESP32/examples/DeepSleep/ExternalWakeUp‼️ +34K‼️ +7K
ESP32/examples/DeepSleep/TimerWakeUp‼️ +35K‼️ +7K
ESP32/examples/DeepSleep/TouchWakeUp‼️ +34K‼️ +6K
ESP32/examples/FreeRTOS/BasicMultiThreading‼️ +15K‼️ +6K
ESP32/examples/FreeRTOS/Mutex‼️ +3K💚 -888
ESP32/examples/FreeRTOS/Queue‼️ +3K💚 -880
BluetoothSerial/examples/DiscoverConnect00
BluetoothSerial/examples/GetLocalMAC00
BluetoothSerial/examples/SerialToSerialBT00
BluetoothSerial/examples/SerialToSerialBTM00
BluetoothSerial/examples/SerialToSerialBT_Legacy00
BluetoothSerial/examples/SerialToSerialBT_SSP00
BluetoothSerial/examples/bt_classic_device_discovery00
BluetoothSerial/examples/bt_remove_paired_devices00
ESP32/examples/FreeRTOS/Semaphore💚 -25K💚 -5K
ESP32/examples/GPIO/BlinkRGB‼️ +4K💚 -912
ESP32/examples/GPIO/FunctionalInterrupt‼️ +3K💚 -1120
ESP32/examples/GPIO/FunctionalInterruptStruct‼️ +3K💚 -1136
ESP32/examples/GPIO/GPIOInterrupt‼️ +3K💚 -1136
ESP32/examples/MacAddress/GetMacAddress‼️ +2K💚 -840
ESP32/examples/RMT/Legacy_RMT_Driver_Compatible‼️ +3K💚 -860
ESP32/examples/RMT/RMTCallback‼️ +5K💚 -1104
ESP32/examples/RMT/RMTLoopback‼️ +6K💚 -912
ESP32/examples/RMT/RMTReadXJT‼️ +5K💚 -1048
ESP32/examples/RMT/RMTWrite_RGB_LED‼️ +5K💚 -920
ESP32/examples/RMT/RMT_CPUFreq_Test‼️ +5K💚 -920
ESP32/examples/RMT/RMT_EndOfTransmissionState‼️ +5K💚 -928
ESP32/examples/HWCDC_Events‼️ +16K💚 -5K
ESP32/examples/RMT/RMT_LED_Blink💚 -26K💚 -5K
ESP32/examples/ResetReason/ResetReason💚 -3K💚 -1072
ESP32/examples/ResetReason/ResetReason2‼️ +3K💚 -904
ESP32/examples/Serial/BaudRateDetect_Demo‼️ +3K💚 -888
ESP32/examples/Serial/OnReceiveError_BREAK_Demo‼️ +3K💚 -896
ESP32/examples/Serial/OnReceive_Demo‼️ +3K💚 -904
ESP32/examples/Serial/RS485_Echo_Demo‼️ +3K💚 -888
ESP32/examples/Serial/RxFIFOFull_Demo‼️ +3K💚 -904
ESP32/examples/Serial/RxTimeout_Demo‼️ +3K💚 -896
ESP32/examples/Serial/Serial_All_CPU_Freqs‼️ +3K💚 -904
ESP32/examples/Serial/Serial_STD_Func_OnReceive‼️ +3K💚 -904
ESP32/examples/Serial/onReceiveExample‼️ +3K💚 -888
ESP32/examples/TWAI/TWAIreceive‼️ +3K💚 -904
ESP32/examples/DeepSleep/SmoothBlink_ULP_Code00
ESP32/examples/TWAI/TWAItransmit💚 -25K💚 -5K
ESP32/examples/Template/ExampleTemplate💚 -26K💚 -5K
ESP32/examples/Time/SimpleTime‼️ +71K‼️ +9K
ESP32/examples/Timer/RepeatTimer‼️ +4K💚 -912
ESP32/examples/Timer/WatchdogTimer‼️ +3K💚 -896
ESP32/examples/Touch/TouchButtonV2‼️ +28K‼️ +4K
ESP32/examples/Touch/TouchInterrupt‼️ +35K‼️ +6K
ESP32/examples/Touch/TouchRead‼️ +34K‼️ +6K
ESP32/examples/Utilities/HEXBuilder‼️ +3K💚 -888
ESP32/examples/Utilities/MD5Builder‼️ +3K💚 -888
ESP32/examples/Utilities/SHA1Builder‼️ +4K💚 -888
ESP_I2S/examples/ES8388_loopback‼️ +15K💚 -952
ESP_I2S/examples/Simple_tone‼️ +12K💚 -904
ESP_I2S/examples/Record_to_WAV‼️ +3K‼️ +2K
ESP_NOW/examples/ESP_NOW_Broadcast_Master‼️ +48K‼️ +3K
ESP_NOW/examples/ESP_NOW_Broadcast_Slave‼️ +48K‼️ +3K
ESP_NOW/examples/ESP_NOW_Network‼️ +71K‼️ +8K
ESP_NOW/examples/ESP_NOW_Serial‼️ +71K‼️ +7K
ESPmDNS/examples/mDNS-SD_Extended‼️ +71K‼️ +7K
ESPmDNS/examples/mDNS_Web_Server‼️ +72K‼️ +7K
Ethernet/examples/ETH_W5500_Arduino_SPI‼️ +18K💚 -764
Ethernet/examples/ETH_W5500_IDF_SPI‼️ +17K💚 -780
Ethernet/examples/ETH_WIFI_BRIDGE‼️ +57K‼️ +7K
FFat/examples/FFat_Test‼️ +7K💚 -852
FFat/examples/FFat_time‼️ +72K‼️ +8K
HTTPClient/examples/Authorization‼️ +71K‼️ +9K
HTTPClient/examples/BasicHttpClient‼️ +71K‼️ +9K
ESP32/examples/Touch/TouchButton00
ESP_SR/examples/Basic00
HTTPClient/examples/BasicHttpsClient‼️ +50K‼️ +5K
HTTPClient/examples/HTTPClientEnterprise‼️ +50K‼️ +5K
HTTPClient/examples/ReuseConnection‼️ +71K‼️ +9K
HTTPClient/examples/StreamHttpClient‼️ +71K‼️ +9K
HTTPUpdate/examples/httpUpdate‼️ +57K‼️ +8K
HTTPUpdate/examples/httpUpdateSPIFFS‼️ +57K‼️ +8K
HTTPUpdate/examples/httpUpdateSecure‼️ +56K‼️ +8K
HTTPUpdateServer/examples/WebUpdater‼️ +55K‼️ +7K
Insights/examples/DiagnosticsSmokeTest‼️ +70K‼️ +7K
Insights/examples/MinimalDiagnostics‼️ +70K‼️ +7K
LittleFS/examples/LITTLEFS_test‼️ +9K💚 -864
LittleFS/examples/LITTLEFS_time‼️ +71K‼️ +8K
NetBIOS/examples/ESP_NBNST‼️ +71K‼️ +7K
NetworkClientSecure/examples/WiFiClientInsecure‼️ +50K‼️ +3K
NetworkClientSecure/examples/WiFiClientPSK‼️ +50K‼️ +3K
NetworkClientSecure/examples/WiFiClientSecure‼️ +50K‼️ +3K
NetworkClientSecure/examples/WiFiClientSecureEnterprise‼️ +71K‼️ +7K
NetworkClientSecure/examples/WiFiClientSecureProtocolUpgrade‼️ +70K‼️ +7K
NetworkClientSecure/examples/WiFiClientShowPeerCredentials‼️ +71K‼️ +9K
NetworkClientSecure/examples/WiFiClientTrustOnFirstUse‼️ +69K‼️ +7K
PPP/examples/PPP_Basic‼️ +7K💚 -728
PPP/examples/PPP_WIFI_BRIDGE‼️ +56K‼️ +7K
Preferences/examples/Prefs2Struct‼️ +3K💚 -888
Preferences/examples/StartCounter⚠️ +1626💚 -896
RainMaker/examples/RMakerCustom‼️ +776K‼️ +22K
RainMaker/examples/RMakerCustomAirCooler‼️ +767K‼️ +22K
Ethernet/examples/ETH_LAN872000
Ethernet/examples/ETH_TLK11000
RainMaker/examples/RMakerSonoffDualR3‼️ +219K💚 -4K
RainMaker/examples/RMakerSwitch‼️ +220K💚 -4K
SD/examples/SD_Test💚 -25K💚 -5K
SD/examples/SD_time‼️ +29K‼️ +3K
SPI/examples/SPI_Multiple_Buses‼️ +17K‼️ +6K
SPIFFS/examples/SPIFFS_Test‼️ +8K💚 -848
SPIFFS/examples/SPIFFS_time‼️ +71K‼️ +8K
TFLiteMicro/examples/hello_world‼️ +6K💚 -880
Ticker/examples/Blinker‼️ +3K💚 -920
Ticker/examples/TickerBasic‼️ +3K💚 -912
Ticker/examples/TickerParameter‼️ +3K💚 -912
USB/examples/CompositeDevice‼️ +48K‼️ +5K
USB/examples/ConsumerControl‼️ +48K‼️ +5K
OpenThread/examples/COAP/coap_lamp‼️ +27K💚 -648
OpenThread/examples/COAP/coap_switch‼️ +27K💚 -648
OpenThread/examples/SimpleCLI‼️ +27K💚 -664
OpenThread/examples/SimpleNode‼️ +27K💚 -664
OpenThread/examples/SimpleThreadNetwork/LeaderNode‼️ +27K💚 -664
OpenThread/examples/SimpleThreadNetwork/RouterNode‼️ +27K💚 -664
OpenThread/examples/ThreadScan‼️ +27K💚 -664
OpenThread/examples/onReceive‼️ +27K💚 -664
SD_MMC/examples/SD2USBMSC00
SD_MMC/examples/SDMMC_Test‼️ +8K‼️ +2K
SD_MMC/examples/SDMMC_time‼️ +47K‼️ +3K
SimpleBLE/examples/SimpleBleDevice‼️ +225K💚 -8K
USB/examples/CustomHIDDevice💚 -48K💚 -5K
USB/examples/FirmwareMSC‼️ +51K‼️ +5K
USB/examples/Gamepad‼️ +48K‼️ +5K
USB/examples/HIDVendor‼️ +48K‼️ +5K
USB/examples/Keyboard/KeyboardLogout‼️ +48K‼️ +5K
USB/examples/Keyboard/KeyboardMessage‼️ +48K‼️ +5K
USB/examples/Keyboard/KeyboardReprogram‼️ +48K‼️ +5K
USB/examples/Keyboard/KeyboardSerial‼️ +51K‼️ +5K
USB/examples/KeyboardAndMouseControl‼️ +48K‼️ +5K
USB/examples/MIDI/MidiController‼️ +48K‼️ +5K
USB/examples/MIDI/MidiInterface‼️ +51K‼️ +5K
USB/examples/MIDI/MidiMusicBox‼️ +48K‼️ +5K
USB/examples/MIDI/ReceiveMidi‼️ +51K‼️ +5K
USB/examples/Mouse/ButtonMouseControl💚 -48K💚 -5K
USB/examples/SystemControl💚 -48K💚 -5K
USB/examples/USBMSC‼️ +51K‼️ +5K
USB/examples/USBSerial‼️ +51K‼️ +5K
USB/examples/USBVendor‼️ +48K‼️ +5K
Update/examples/AWS_S3_OTA_Update‼️ +26K‼️ +4K
Update/examples/HTTPS_OTA_Update‼️ +21K‼️ +4K
Update/examples/HTTP_Client_AES_OTA_Update‼️ +56K‼️ +8K
Update/examples/HTTP_Server_AES_OTA_Update‼️ +55K‼️ +7K
Update/examples/OTAWebUpdater‼️ +55K‼️ +7K
Update/examples/SD_Update‼️ +6K💚 -924
WebServer/examples/AdvancedWebServer‼️ +56K‼️ +7K
WebServer/examples/FSBrowser‼️ +73K‼️ +7K
WebServer/examples/Filters‼️ +4K‼️ +5K
WebServer/examples/HelloServer‼️ +4K‼️ +5K
WebServer/examples/HttpAdvancedAuth‼️ +4K‼️ +5K
WebServer/examples/HttpAuthCallback💚 -26K‼️ +2K
WebServer/examples/HttpAuthCallbackInline‼️ +25K‼️ +4K
WebServer/examples/HttpBasicAuth‼️ +25K‼️ +4K
WebServer/examples/HttpBasicAuthSHA1‼️ +25K‼️ +4K
WebServer/examples/HttpBasicAuthSHA1orBearerToken‼️ +55K‼️ +7K
WebServer/examples/MultiHomedServers‼️ +56K‼️ +7K
WebServer/examples/PathArgServer‼️ +74K‼️ +9K
WebServer/examples/SDWebServer‼️ +57K‼️ +7K
WebServer/examples/SimpleAuthentification‼️ +71K‼️ +7K
WebServer/examples/UploadHugeFile‼️ +58K‼️ +8K
WebServer/examples/WebServer‼️ +27K‼️ +6K
WebServer/examples/WebUpdate‼️ +3K‼️ +5K
WiFi/examples/FTM/FTM_Initiator‼️ +20K‼️ +6K
WiFi/examples/FTM/FTM_Responder‼️ +21K‼️ +6K
WiFi/examples/SimpleWiFiServer‼️ +26K‼️ +4K
WiFi/examples/WPS‼️ +22K‼️ +4K
WiFi/examples/WiFiAccessPoint‼️ +26K‼️ +4K
WiFi/examples/WiFiClient‼️ +71K‼️ +7K
WiFi/examples/WiFiClientBasic‼️ +71K‼️ +7K
WiFi/examples/WiFiClientConnect‼️ +69K‼️ +7K
WiFi/examples/WiFiClientEnterprise‼️ +71K‼️ +7K
WiFi/examples/WiFiClientEvents‼️ +70K‼️ +7K
WiFi/examples/WiFiClientStaticIP‼️ +71K‼️ +7K
WiFi/examples/WiFiBlueToothSwitch‼️ +48K‼️ +12K
WiFi/examples/WiFiExtender‼️ +21K‼️ +6K
WiFi/examples/WiFiIPv6‼️ +20K‼️ +6K
WiFi/examples/WiFiMulti‼️ +21K‼️ +6K
Wire/examples/WireMaster‼️ +31K‼️ +7K
Wire/examples/WireScan‼️ +31K‼️ +7K
WiFi/examples/WiFiMultiAdvanced‼️ +50K‼️ +5K
WiFi/examples/WiFiScan‼️ +22K‼️ +4K
WiFi/examples/WiFiScanAsync‼️ +22K‼️ +4K
WiFi/examples/WiFiScanDualAntenna‼️ +71K‼️ +7K
WiFi/examples/WiFiScanTime‼️ +71K‼️ +7K
WiFi/examples/WiFiSmartConfig‼️ +73K‼️ +7K
WiFi/examples/WiFiTelnetToSerial‼️ +71K‼️ +7K
WiFi/examples/WiFiUDPClient‼️ +71K‼️ +7K
WiFiProv/examples/WiFiProv‼️ +782K‼️ +21K
Wire/examples/WireSlave‼️ +76K‼️ +8K

P-R-O-C-H-Y
P-R-O-C-H-Y approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@P-R-O-C-H-Y P-R-O-C-H-Y added the Area: Peripherals API Relates to peripheral's APIs. label Sep 9, 2024
@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Sep 9, 2024
@me-no-dev me-no-dev merged commit 532d5f2 into master Sep 9, 2024
87 checks passed
@me-no-dev me-no-dev deleted the tone_set_channel branch September 9, 2024 09:45
@nomakewan nomakewan mentioned this pull request Sep 17, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

@lucasssvaz lucasssvaz Awaiting requested review from lucasssvaz

@me-no-dev me-no-dev Awaiting requested review from me-no-dev

Assignees

@SuGlider SuGlider

Labels
Area: Peripherals API Relates to peripheral's APIs. Status: Pending Merge Pull Request is ready to be merged
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
3.0.5
Development

Successfully merging this pull request may close these issues.

setToneChannel is declared but not implemented in v3.0.4
3 participants
@SuGlider @P-R-O-C-H-Y @me-no-dev